Skip to content

Perform post copy actions in atomic copy#18411

Merged
rohit-nayak-ps merged 2 commits intovitessio:mainfrom
beingnoble03:pca-atomic-copy
Jul 4, 2025
Merged

Perform post copy actions in atomic copy#18411
rohit-nayak-ps merged 2 commits intovitessio:mainfrom
beingnoble03:pca-atomic-copy

Conversation

@beingnoble03
Copy link
Member

@beingnoble03 beingnoble03 commented Jul 2, 2025 •
edited
Loading

Description

This PR

  • fixes the atomic copy behaviour (specifically in copyAll()) where we missed executing post copy actions.
  • Also, modifies the test TestFKWorkflow to confirm secondary keys in the target schema.
  • Also deletes the executed post copy actions from _vt. post_copy_action along with the existing state deletion from _vt.copy_state

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@beingnoble03
Perform post copy actions in atomic copy
ff3402d 
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 2, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 2, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (d429368) to head (e772d2a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ablet/tabletmanager/vreplication/vcopier_atomic.go 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18411      +/-   ##
==========================================
- Coverage   67.51%   67.50%   -0.02%     
==========================================
  Files        1607     1607              
  Lines      262684   262699      +15     
==========================================
- Hits       177343   177325      -18     
- Misses      85341    85374      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@beingnoble03
test: Modify e2e test TestFKWorkflow to test defer-secondary-keys
e772d2a 
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
@beingnoble03 beingnoble03 added Type: Bug Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 2, 2025
@beingnoble03 beingnoble03 marked this pull request as ready for review July 2, 2025 11:02
mattlord
mattlord approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a new test included here, which fails on main and passes in the PR branch. From looking at the code, this should be good. But any fix should have a corresponding test that confirms 1. it catches the bug and reproduces the failure 2. that the fix actually fixes it.

@beingnoble03
Copy link
Member Author

beingnoble03 commented Jul 3, 2025

Hi @mattlord, TestFKWorkflow was modified here to do so. This test fails on main, but passes in this PR.

@mattlord
Copy link
Member

mattlord commented Jul 3, 2025

Hi @mattlord, TestFKWorkflow was modified here to do so. This test fails on main, but passes in this PR.

Ah, I see! I didn't originally pick up on that from the snippet in the diff but when expanding it it's clear. Sorry about that. ❤️

@rohit-nayak-ps rohit-nayak-ps merged commit 683f740 into vitessio:main Jul 4, 2025
108 of 118 checks passed
@GrahamCampbell
Copy link
Contributor

GrahamCampbell commented Jul 4, 2025

Should this be backported?

morgo added a commit to morgo/vitess that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into fix-topo-import-to-…
aa4be6e 
…tests

* origin/master: (32 commits)
  test: Fix race condition in TestStreamRowsHeartbeat (vitessio#18414)
  VReplication: Improve permission check logic on external tablets on SwitchTraffic (vitessio#18348)
  Perform post copy actions in atomic copy (vitessio#18411)
  Update `operator.yaml` (vitessio#18364)
  Feature(onlineddl): Add shard-specific completion to online ddl (vitessio#18331)
  Set parsed comments in operator for subqueries (vitessio#18369)
  `vtorc`: move shard primary timestamp to time type (vitessio#18401)
  `vtorc`: rename `isClusterWideRecovery` -> `isShardWideRecovery` (vitessio#18351)
  `vtorc`: remove dupe keyspace/shard in replication analysis (vitessio#18395)
  Topo: Add NamedLock test for zk2 and consul and get them passing (vitessio#18407)
  Handle MySQL 9.x as New Flavor in getFlavor() (vitessio#18399)
  Add support for sending grpc server backend metrics via ORCA (vitessio#18282)
  asthelpergen: add design documentation (vitessio#18403)
  `vtorc`: add keyspace/shard labels to recoveries stats (vitessio#18304)
  `vtorc`: cleanup `database_instance` location fields (vitessio#18339)
  avoid derived tables for UNION when possible (vitessio#18393)
  [Bugfix] Broken Heartbeat system in Row Streamer (vitessio#18390)
  Update MAINTAINERS.md (vitessio#18394)
  move vmg to emeritus (vitessio#18388)
  Make sure to check if the server is closed in etcd2topo (vitessio#18352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit

@deepthi deepthi Awaiting requested review from deepthi

Assignees

No one assigned

Labels

Component: VReplication Type: Bug

Projects

None yet

Milestone

v23.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: Deferred secondary keys are not re-added after the copy phase completes with atomic copy

4 participants

@beingnoble03 @mattlord @GrahamCampbell @rohit-nayak-ps