Ahoyapps 46 dominant speaker area #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
charliesantos
requested changes
Oct 31, 2019
| <Container> | ||
| <ParticipantStrip /> | ||
| <MainParticipantContainer> | ||
| <Participant participant={mainParticipant} disableAudio /> |
Collaborator
There was a problem hiding this comment.
Is audio disabled by default in VBT?
Contributor
Author
There was a problem hiding this comment.
disableAudio prevents an <audio> element from being rendered for this participant. I'm doing this here because this participant's <audio> element is already rendered in the <ParticipantStrip /> component.
Collaborator
There was a problem hiding this comment.
Got it. Can you add a comment on this line and put what you just said?
added 2 commits
October 31, 2019 10:06
charliesantos
approved these changes
Oct 31, 2019
timmydoza
pushed a commit
that referenced
this pull request
Mar 6, 2020
* Add new hooks and tests * Add main participant to room component * Move sidebar position to theme * Lint * Disable main participant's audio as it will already be rendered in the ParticipantStrip * Typo * Change import order * Fix circleci * Add comment
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Add new hooks and tests * Add main participant to room component * Move sidebar position to theme * Lint * Disable main participant's audio as it will already be rendered in the ParticipantStrip * Typo * Change import order * Fix circleci * Add comment
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Add new hooks and tests * Add main participant to room component * Move sidebar position to theme * Lint * Disable main participant's audio as it will already be rendered in the ParticipantStrip * Typo * Change import order * Fix circleci * Add comment
gabriel-jt
added a commit
that referenced
this pull request
Jul 2, 2021
…ublic folder (#8) * Added npm script to copy video processor sdk assets to public folder * added postinstall npm script Co-authored-by: Gabe Espinosa <[email protected]>
charliesantos
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Moved more menu to the center of the menu bar * VIDEO-5731 | Added background option to More Menu, selection dialog, and unit tests (#6) Added background option to More Menu, selection dialog, and unit tests Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-5733 | Added npm script to copy video processor sdk assets to public folder (#8) * Added npm script to copy video processor sdk assets to public folder * added postinstall npm script Co-authored-by: Gabe Espinosa <[email protected]> * added rimraf and copyfiles dependency to package.json * VIDEO-5732 | Added background selection UI (#7) Added background selection UI Co-authored-by: Gabe Espinosa <[email protected]> Co-authored-by: timmydoza <[email protected]> * VIDEO-5734/blur background feature (#550) Implemented blur background feature (useBackgroundSettings hook and tests) Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-5735/Add virtual background feature (#557) Added virtual background feature and unit tests Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-5735 | Add isSupported check and unit test (#560) add isSupported check and unit test Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-6368 | wait to load image before removing processor (#570) * wait to load image before removing processor Co-authored-by: Gabe Espinosa <[email protected]> * updated twilio-video sdk * fixed breaking tests * update package.json version and changelog * update change log, package.json, and revisions * Update CHANGELOG.md Co-authored-by: Gabe Espinosa <[email protected]> Co-authored-by: timmydoza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays the main speaker's video in the main section of the app.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR will display the main speaker's video. The 'main speaker' will be chosen in the following order:
This behavior is modeled off of the existing VBT app.
Burndown
Before review
npm testBefore merge