VIDEO-5735/Add virtual background feature#557
Merged
gabriel-jt merged 2 commits intofeature/virtualbackgroundfrom Jul 26, 2021
Merged
VIDEO-5735/Add virtual background feature#557gabriel-jt merged 2 commits intofeature/virtualbackgroundfrom
gabriel-jt merged 2 commits intofeature/virtualbackgroundfrom
Conversation
charliesantos
requested changes
Jul 23, 2021
Collaborator
charliesantos
left a comment
charliesantos
left a comment
There was a problem hiding this comment.
Great work Gabe! I like how simple it looks :)
Just a couple of comments. Also, please make sure CI passes.
| "ts-node": "^9.1.1", | ||
| "twilio": "3.63.1", | ||
| "twilio-video": "^2.14.0", | ||
| "twilio-video": "^2.15.2", |
Collaborator
There was a problem hiding this comment.
Can you also please update @twilio/video-processors to latest?
| backgroundSettings = renderResult.current[0]; | ||
| expect(backgroundSettings.type).toEqual('image'); | ||
| expect(backgroundSettings.index).toEqual(2); | ||
| expect(mockVideoTrack.addProcessor).toHaveBeenCalled(); |
Collaborator
There was a problem hiding this comment.
Can we have a test that checks addProcessor was called with the virtualBackground param? I think we need to update line 75 as well. Check addProcessor was called with the blur processor param.
charliesantos
approved these changes
Jul 26, 2021
charliesantos
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Moved more menu to the center of the menu bar * VIDEO-5731 | Added background option to More Menu, selection dialog, and unit tests (#6) Added background option to More Menu, selection dialog, and unit tests Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> * VIDEO-5733 | Added npm script to copy video processor sdk assets to public folder (#8) * Added npm script to copy video processor sdk assets to public folder * added postinstall npm script Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> * added rimraf and copyfiles dependency to package.json * VIDEO-5732 | Added background selection UI (#7) Added background selection UI Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> Co-authored-by: timmydoza <tmendoza@twilio.com> * VIDEO-5734/blur background feature (#550) Implemented blur background feature (useBackgroundSettings hook and tests) Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> * VIDEO-5735/Add virtual background feature (#557) Added virtual background feature and unit tests Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> * VIDEO-5735 | Add isSupported check and unit test (#560) add isSupported check and unit test Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> * VIDEO-6368 | wait to load image before removing processor (#570) * wait to load image before removing processor Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> * updated twilio-video sdk * fixed breaking tests * update package.json version and changelog * update change log, package.json, and revisions * Update CHANGELOG.md Co-authored-by: Gabe Espinosa <gespinosa@twilio.com> Co-authored-by: timmydoza <tmendoza@twilio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
Added virtual background feature
Before review
npm testBefore merge