Skip to content

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Oct 28, 2019

This PR adds unit tests for the functionality that was previously added for AHOYAPPS-40.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

Adds unit tests for React components and hooks.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza self-assigned this Oct 28, 2019
Copy link
Collaborator

@charliesantos charliesantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Everything else looks good!

@charliesantos charliesantos merged commit ef13ce5 into development Oct 29, 2019
@charliesantos charliesantos deleted the AHOYAPPS-40-enter/leave-room-tests branch October 29, 2019 15:38
timmydoza pushed a commit that referenced this pull request Mar 6, 2020
timmydoza pushed a commit that referenced this pull request Sep 30, 2020
AHOYAPPS-733 Pass LocalTracks to ConnectOptions and disable audio/video toggling.
uriasn pushed a commit to Mastermind-com/twilio-video-app-react that referenced this pull request Oct 6, 2020
uriasn pushed a commit to Mastermind-com/twilio-video-app-react that referenced this pull request Oct 6, 2020
gabriel-jt added a commit that referenced this pull request Jul 2, 2021
…and unit tests (#6)

Added background option to More Menu, selection dialog, and unit tests
Co-authored-by: Gabe Espinosa <[email protected]>
charliesantos pushed a commit that referenced this pull request Aug 9, 2021
* Moved more menu to the center of the menu bar

* VIDEO-5731 | Added background option to More Menu, selection dialog, and unit tests (#6)

Added background option to More Menu, selection dialog, and unit tests
Co-authored-by: Gabe Espinosa <[email protected]>

* VIDEO-5733 | Added npm script to copy video processor sdk assets to public folder (#8)

* Added npm script to copy video processor sdk assets to public folder

* added postinstall npm script

Co-authored-by: Gabe Espinosa <[email protected]>

* added rimraf and copyfiles dependency to package.json

* VIDEO-5732 | Added background selection UI (#7)

Added background selection UI

Co-authored-by: Gabe Espinosa <[email protected]>
Co-authored-by: timmydoza <[email protected]>

* VIDEO-5734/blur background feature (#550)

Implemented blur background feature (useBackgroundSettings hook and tests)
Co-authored-by: Gabe Espinosa <[email protected]>

* VIDEO-5735/Add virtual background feature (#557)

Added virtual background feature and unit tests
Co-authored-by: Gabe Espinosa <[email protected]>

* VIDEO-5735 | Add isSupported check and unit test (#560)

add isSupported check and unit test
Co-authored-by: Gabe Espinosa <[email protected]>

* VIDEO-6368 | wait to load image before removing processor (#570)

* wait to load image before removing processor
Co-authored-by: Gabe Espinosa <[email protected]>

* updated twilio-video sdk

* fixed breaking tests

* update package.json version and changelog

* update change log, package.json, and revisions

* Update CHANGELOG.md

Co-authored-by: Gabe Espinosa <[email protected]>
Co-authored-by: timmydoza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants