Merge feature/virtualbackground onto master #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIDEO-5730 | Moved more menu to the center of the menu bar
…and unit tests (#6) Added background option to More Menu, selection dialog, and unit tests Co-authored-by: Gabe Espinosa <[email protected]>
…ublic folder (#8) * Added npm script to copy video processor sdk assets to public folder * added postinstall npm script Co-authored-by: Gabe Espinosa <[email protected]>
VIDEO-5733 | added rimraf and copyfiles dependency to package.json
Added background selection UI Co-authored-by: Gabe Espinosa <[email protected]> Co-authored-by: timmydoza <[email protected]>
Implemented blur background feature (useBackgroundSettings hook and tests) Co-authored-by: Gabe Espinosa <[email protected]>
Added virtual background feature and unit tests Co-authored-by: Gabe Espinosa <[email protected]>
add isSupported check and unit test Co-authored-by: Gabe Espinosa <[email protected]>
* wait to load image before removing processor Co-authored-by: Gabe Espinosa <[email protected]>
VIDEO-6399 | Update twilio-video sdk
gabriel-jt
requested review from
charliesantos and
timmydoza
and removed request for
timmydoza
charliesantos
previously approved these changes
Aug 6, 2021
Collaborator
charliesantos
left a comment
charliesantos
left a comment
There was a problem hiding this comment.
Let's get @timmydoza 's +1 before merging.
timmydoza
suggested changes
Aug 6, 2021
Contributor
timmydoza
left a comment
timmydoza
left a comment
There was a problem hiding this comment.
Nearly there! Just some quick changes needed...
src/components/MenuBar/MenuBar.tsx
Outdated
| <Grid style={{ flex: 1 }}> | ||
| <Grid container justifyContent="flex-end"> | ||
| <Menu /> | ||
| <Grid container justify="flex-end"> |
Contributor
There was a problem hiding this comment.
This should be justifyContent="flex-end". There's a warning in the console about it (but only when when browser width is reduced to show the mobile styles).
package.json
Outdated
| "@types/lodash.throttle": "^4.1.6", | ||
| "@types/node": "^12.12.26", | ||
| "@types/react": "^16.9.19", | ||
| "@types/react": "17.0.11", |
Contributor
There was a problem hiding this comment.
Let's keep React at ^16.9.19
CHANGELOG.md
Outdated
|
|
||
| ### New Feature | ||
|
|
||
| - This release adds a virtual background feature. This feature allows users to blur their background or apply a background image from the background selection window. The virtual backgrounds are applied to the video tracks using the [Twilio Video Processors SDK](https://www.twilio.com/docs/video/video-processors). For more information, please view this [blog post](https://www.twilio.com/blog/introducing-virtual-backgrounds-browser-based-video-applications). |
Contributor
There was a problem hiding this comment.
Nice description! Let's add a link to the PR at the end of the description:
Suggested change
| - This release adds a virtual background feature. This feature allows users to blur their background or apply a background image from the background selection window. The virtual backgrounds are applied to the video tracks using the [Twilio Video Processors SDK](https://www.twilio.com/docs/video/video-processors). For more information, please view this [blog post](https://www.twilio.com/blog/introducing-virtual-backgrounds-browser-based-video-applications). | |
| - This release adds a virtual background feature. This feature allows users to blur their background or apply a background image from the background selection window. The virtual backgrounds are applied to the video tracks using the [Twilio Video Processors SDK](https://www.twilio.com/docs/video/video-processors). For more information, please view this [blog post](https://www.twilio.com/blog/introducing-virtual-backgrounds-browser-based-video-applications). [#574](https://github.com/twilio/twilio-video-app-react/pull/574) |
| ### New Feature | ||
|
|
||
| - This release adds a virtual background feature. This feature allows users to blur their background or apply a background image from the background selection window. The virtual backgrounds are applied to the video tracks using the [Twilio Video Processors SDK](https://www.twilio.com/docs/video/video-processors). For more information, please view this [blog post](https://www.twilio.com/blog/introducing-virtual-backgrounds-browser-based-video-applications). | ||
|
|
Contributor
There was a problem hiding this comment.
Also here let's add information about the package upgrades that happened in #568.
### Dependency Upgrades
-`@material-ui/core` has been updated from 4.9.1. to 4.12.3. [#568](https://github.com/twilio/twilio-video-app-react/pull/568)
-`@material-ui/icons` has been updated from 4.9.1. to 4.11.12. [#568](https://github.com/twilio/twilio-video-app-react/pull/568)
-`@twilio/conversations` has been updated from 1.1.0. to 1.2.3. [#568](https://github.com/twilio/twilio-video-app-react/pull/568)
Contributor
|
Also, when I run |
charliesantos
approved these changes
Aug 9, 2021
timmydoza
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
Merge the virtual background feature onto master
Burndown
Before review
npm testBefore merge