Ahoyapps 47 create participant filmstrip #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
October 28, 2019 15:02
Contributor
Author
|
|
charliesantos
requested changes
Oct 29, 2019
Collaborator
charliesantos
left a comment
charliesantos
left a comment
There was a problem hiding this comment.
Looking good @timmydoza ! Very easy to read!
Just left a few comments.
| '&:not(:last-child)': { | ||
| borderRight: 'none', | ||
| }, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Not part of this PR but just a thought. How would we pass custom styles if I want to reuse this component?
src/components/NewtorkQualityLevel/__snapshots__/NetworkQualityLevel.test.tsx.snap
Show resolved
Hide resolved
src/components/ParticipantInfo/__snapshots__/ParticipantInfo.test.tsx.snap
Show resolved
Hide resolved
src/components/ParticipantStrip/__snapshots__/ParticipantStrip.test.tsx.snap
Show resolved
Hide resolved
charliesantos
approved these changes
Oct 30, 2019
timmydoza
pushed a commit
that referenced
this pull request
Mar 6, 2020
* Add Participant, publication, and Track components and hooks * Apply basic styles to ParticipantStrip * Add AudioTrack component * Add Network quality states to ParticipantStrip * Style adjustments for network quality * Clean up network quality appearance and code * Fix some bugs in useRoom and useParticipants hooks * Fix network quality level * Fix useRoom tests * Add more testing dependencies * fix networkQuality hook * Add more tests * Add more tests for hooks * Add tests for Participant and Publication * Add test for participantStrip component * Tidy up tests a little * Let Participant component decide if it was passed the localParticipant * Adjust import orders * Restructure participant component * Delete file created on accident * Rename type
timmydoza
pushed a commit
that referenced
this pull request
Sep 30, 2020
…creens Feature/design refresh pre join screens
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Add Participant, publication, and Track components and hooks * Apply basic styles to ParticipantStrip * Add AudioTrack component * Add Network quality states to ParticipantStrip * Style adjustments for network quality * Clean up network quality appearance and code * Fix some bugs in useRoom and useParticipants hooks * Fix network quality level * Fix useRoom tests * Add more testing dependencies * fix networkQuality hook * Add more tests * Add more tests for hooks * Add tests for Participant and Publication * Add test for participantStrip component * Tidy up tests a little * Let Participant component decide if it was passed the localParticipant * Adjust import orders * Restructure participant component * Delete file created on accident * Rename type
uriasn
pushed a commit
to Mastermind-com/twilio-video-app-react
that referenced
this pull request
Oct 6, 2020
* Add Participant, publication, and Track components and hooks * Apply basic styles to ParticipantStrip * Add AudioTrack component * Add Network quality states to ParticipantStrip * Style adjustments for network quality * Clean up network quality appearance and code * Fix some bugs in useRoom and useParticipants hooks * Fix network quality level * Fix useRoom tests * Add more testing dependencies * fix networkQuality hook * Add more tests * Add more tests for hooks * Add tests for Participant and Publication * Add test for participantStrip component * Tidy up tests a little * Let Participant component decide if it was passed the localParticipant * Adjust import orders * Restructure participant component * Delete file created on accident * Rename type
gabriel-jt
added a commit
that referenced
this pull request
Jul 2, 2021
Added background selection UI Co-authored-by: Gabe Espinosa <[email protected]> Co-authored-by: timmydoza <[email protected]>
charliesantos
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Moved more menu to the center of the menu bar * VIDEO-5731 | Added background option to More Menu, selection dialog, and unit tests (#6) Added background option to More Menu, selection dialog, and unit tests Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-5733 | Added npm script to copy video processor sdk assets to public folder (#8) * Added npm script to copy video processor sdk assets to public folder * added postinstall npm script Co-authored-by: Gabe Espinosa <[email protected]> * added rimraf and copyfiles dependency to package.json * VIDEO-5732 | Added background selection UI (#7) Added background selection UI Co-authored-by: Gabe Espinosa <[email protected]> Co-authored-by: timmydoza <[email protected]> * VIDEO-5734/blur background feature (#550) Implemented blur background feature (useBackgroundSettings hook and tests) Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-5735/Add virtual background feature (#557) Added virtual background feature and unit tests Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-5735 | Add isSupported check and unit test (#560) add isSupported check and unit test Co-authored-by: Gabe Espinosa <[email protected]> * VIDEO-6368 | wait to load image before removing processor (#570) * wait to load image before removing processor Co-authored-by: Gabe Espinosa <[email protected]> * updated twilio-video sdk * fixed breaking tests * update package.json version and changelog * update change log, package.json, and revisions * Update CHANGELOG.md Co-authored-by: Gabe Espinosa <[email protected]> Co-authored-by: timmydoza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the sidebar of participant thumbnails.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
The pariticipant sidebar (called the ParticipantStrip component after a discussion with Kevin) renders audio and video tracks for all participants, and also displays their name and network quality information. Participants are added or removed to the sidebar as they join or leave the room.
Burndown
Before review
npm testBefore merge