Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop webpack 3 support #915

Closed
3 of 4 tasks
sapegin opened this issue Apr 1, 2018 · 3 comments
Closed
3 of 4 tasks

Drop webpack 3 support #915

sapegin opened this issue Apr 1, 2018 · 3 comments
Labels
good first issue Good for newcomers help wanted technical debt
Milestone
8.0.0: No webpack 3

Comments

@sapegin
Copy link
Member

sapegin commented Apr 1, 2018 •
edited
Loading

Looks like there's no way to support both at the same time and avoid deprecation warning on both versions. Let's wait for webpack 4 support in Create React App, and drop webpack 3 support in Styleguidist.
@sapegin sapegin added this to the 8.0.0 milestone Apr 1, 2018
@sapegin sapegin mentioned this issue Apr 1, 2018
Closed
@sapegin sapegin added the good first issue Good for newcomers label Apr 1, 2018
@stepancar stepancar mentioned this issue Jun 24, 2018
Merged
@stevematney stevematney mentioned this issue Sep 7, 2018
Merged
@jklemm
Copy link

jklemm commented Oct 4, 2018 •
edited
Loading

Is this PR related to this warnings?

warning "react-styleguidist > [email protected]" has incorrect peer dependency "[email protected] || 0.13.0".
warning "react-styleguidist > [email protected]" has incorrect peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "react-styleguidist > webpack-dev-server > [email protected]" has incorrect peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".

I'm using webpack==4.17.2, webpack-dev-server==3.1.9.

@SavePointSam
Copy link

Create React App 2.0 has been released with Webpack 4 support.

@AndreyGladkov
Copy link

Remove webpack-dev-server warning #1180

sapegin pushed a commit that referenced this issue Oct 23, 2018
Changelog: 🚀
8e79531 
## Breaking changes

### Drop webpack 3 support

Webpack 3 is no longer supported, webpack 4 is the minimum required version.

As a side effect you shouldn’t see any webpack warnings when you run Styleguidist.

We’ve also replaced no longer maintainer uglify-es with Terser to minify production JavaScript bundle.

* #1175, #1178 by @derz
* #1165 by @elevatebart
* #1148 by @elevatebart
* #915, #1023 by @stepancar
* #1180 by @AndreyGladkov
@sapegin sapegin closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted technical debt
Projects
None yet
Milestone
8.0.0: No webpack 3
Development

No branches or pull requests
4 participants
@sapegin @AndreyGladkov @jklemm @SavePointSam