Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: replaces UglifyJS with Terser (#1175) #1178

Closed
wants to merge 2 commits into from

Conversation

derz
Copy link
Contributor

@derz derz commented Oct 17, 2018

#1175

  • 1:1 replacement as the options haven't changed (yet)

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Please update package-lock.json (run npm install and commit the file) to make CI work.

@@ -32,7 +32,7 @@
"acorn": "^6.0.2",
"acorn-jsx": "^5.0.0",
"ast-types": "^0.11.6",
"buble": "^0.19.4",
"buble": "0.19.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed in master already, could you please merge master into your branch?

@sapegin sapegin added this to the 9.0.0: No webpack 3 milestone Oct 17, 2018
sapegin pushed a commit that referenced this pull request Oct 18, 2018
Replace unmaintained uglify-es with terser.

Original commit by @derz — #1178

Closes #1175
sapegin pushed a commit that referenced this pull request Oct 23, 2018
## Breaking changes

### Drop webpack 3 support

Webpack 3 is no longer supported, webpack 4 is the minimum required version.

As a side effect you shouldn’t see any webpack warnings when you run Styleguidist.

We’ve also replaced no longer maintainer uglify-es with Terser to minify production JavaScript bundle.

* #1175, #1178 by @derz
* #1165 by @elevatebart
* #1148 by @elevatebart
* #915, #1023 by @stepancar
* #1180 by @AndreyGladkov
@derz derz closed this Oct 23, 2018
@derz derz deleted the feature/next-terser branch October 23, 2018 12:26
sapegin pushed a commit that referenced this pull request Nov 7, 2018
Replace unmaintained uglify-es with terser.

Original commit by @derz — #1178

Closes #1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants