Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-dev-server → webpack-serve #916

Closed
sapegin opened this issue Apr 1, 2018 · 6 comments
Closed

webpack-dev-server → webpack-serve #916

sapegin opened this issue Apr 1, 2018 · 6 comments

Comments

@sapegin
Copy link
Member

sapegin commented Apr 1, 2018

webpack-dev-server is in maintenance mode, webpack-serve is a newer faster alternative. It work only in webpack 4, so we have to wait until #915.

@sapegin sapegin added this to the 8.0.0 milestone Apr 1, 2018
@everdimension
Copy link
Contributor

By the way, shouldn't webpack be listed in either peerDependencies or dependencies?

@sapegin
Copy link
Member Author

sapegin commented Jul 23, 2018

Nope, because we should support tools like Create React App that have their own webpack, so you don't have it as a dependency of your project. But if Styleguidist couldn't load webpack, it will ask you to install it.

@everdimension
Copy link
Contributor

Thing is, you rely on webpack either way. But you rely on it implicitly.

I updated my project to webpack v4 and now I see warnings because webpack-dev-middleware and webpack-dev-server, which you have as dependencies, need webpack <=3.

If you had webpack v3 as an explicit dependency, npm would just install it alongside my webpack v4.

But because you do not specify webpack in dependencies, I'm stuck with the warning (styleguidist still works, though).

@sapegin
Copy link
Member Author

sapegin commented Jul 23, 2018

We support webpack 3 and 4, so you’ll likely see some warnings in both cases, but it works somehow. We’ll drop webpack 3 as soon as CRA supports webpack 4, but there are other issues with that (like #987), and then we could upgrade dependencies and get rid of warnings.

@marcofugaro
Copy link

Not anymore, webpack-serve has been deprecated

https://github.com/webpack-contrib/webpack-serve

@sapegin
Copy link
Member Author

sapegin commented Sep 18, 2018

@marcofugaro Awesome, let's close this then ;-)

@sapegin sapegin closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants