-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack-dev-server → webpack-serve #916
Comments
By the way, shouldn't |
Nope, because we should support tools like Create React App that have their own webpack, so you don't have it as a dependency of your project. But if Styleguidist couldn't load webpack, it will ask you to install it. |
Thing is, you rely on webpack either way. But you rely on it implicitly. I updated my project to webpack If you had webpack But because you do not specify webpack in dependencies, I'm stuck with the warning (styleguidist still works, though). |
We support webpack 3 and 4, so you’ll likely see some warnings in both cases, but it works somehow. We’ll drop webpack 3 as soon as CRA supports webpack 4, but there are other issues with that (like #987), and then we could upgrade dependencies and get rid of warnings. |
Not anymore, webpack-serve has been deprecated https://github.com/webpack-contrib/webpack-serve |
@marcofugaro Awesome, let's close this then ;-) |
webpack-dev-server is in maintenance mode, webpack-serve is a newer faster alternative. It work only in webpack 4, so we have to wait until #915.
The text was updated successfully, but these errors were encountered: