Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): drop webpack3 support #1023

Merged
merged 3 commits into from
Oct 18, 2018
Merged

chore(*): drop webpack3 support #1023

merged 3 commits into from
Oct 18, 2018

Conversation

stepancar
Copy link
Member

@stepancar stepancar changed the title chore(*): remove webpack3 support chore(*): drop webpack3 support Jun 24, 2018
@codecov-io
Copy link

codecov-io commented Jun 24, 2018 •
edited
Loading

Codecov Report

Merging #1023 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted Files Coverage Δ
scripts/make-webpack-config.js 100% <100%> (+4.54%) ⬆️
scripts/utils/ensureWebpack.js 77.77% <100%> (ø) ⬆️

@stepancar
Copy link
Member Author

@sapegin we should mock copy-webpack-plugin to check parameters passed to it constructor.
I tried mock using jest 22 and faced with problems. This example not working in jest 22. Its reason why i switched to jest 23.

@stepancar stepancar requested review from sapegin and okonet June 25, 2018 09:39
@sapegin
Copy link
Member

sapegin commented Jun 25, 2018

Thanks! This is awesome! Though we have to wait for CRA2 final release.

Jest 23 is awesome too! Could you please send it as a separate PR? We could merge it right away.

@sapegin sapegin added this to the 8.0.0 milestone Jun 25, 2018
@stepancar
Copy link
Member Author

@sapegin we need update package-lock. Now master crashes after update package-lock
Look at #1030

After it will be closed - I will create Jest23 migration PR

@stepancar
Copy link
Member Author

@sapegin , #1034

@styleguidist-bot
Copy link
Collaborator

Warnings
⚠️

Changes were made to package-lock.json, but not to package.json.

Please remove package-lock.json changes from your pull request. Try to run git checkout master -- package-lock.json and commit changes.

Generated by 🚫 dangerJS

@sapegin sapegin merged commit 621c2c6 into master Oct 18, 2018
@sapegin sapegin deleted the chore/remove-webpack3-support branch October 18, 2018 08:04
sapegin pushed a commit that referenced this pull request Oct 23, 2018
Changelog: 🚀
8e79531 
## Breaking changes

### Drop webpack 3 support

Webpack 3 is no longer supported, webpack 4 is the minimum required version.

As a side effect you shouldn’t see any webpack warnings when you run Styleguidist.

We’ve also replaced no longer maintainer uglify-es with Terser to minify production JavaScript bundle.

* #1175, #1178 by @derz
* #1165 by @elevatebart
* #1148 by @elevatebart
* #915, #1023 by @stepancar
* #1180 by @AndreyGladkov
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sapegin pushed a commit that referenced this pull request Nov 7, 2018
@stepancar
Feat: Drop webpack 3 support (#1023)
5e8f34b 
BREAKING CHANGE:

webpack 3 is no longer supported, webpack 4 is the minimum required version
This was referenced Apr 7, 2021
Open
Open
Open
Open
Open
Open
This was referenced May 6, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 25, 2021
Open
This was referenced May 26, 2021
Open
Open
This was referenced Aug 17, 2021
Open
Open
This was referenced Sep 12, 2021
Open
Open
Open
@Bhanditz Bhanditz mentioned this pull request May 16, 2022
Open
@kopax kopax mentioned this pull request May 17, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapegin sapegin sapegin approved these changes

@okonet okonet Awaiting requested review from okonet

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
8.0.0: No webpack 3
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancar @codecov-io @sapegin @styleguidist-bot