Up webpack, dev-server, merge, eslint-plugin-compat, react-dev-utils add webpack to peer #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
requested changes
Oct 18, 2018
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "react": ">=15", | ||
| "react-dom": ">=15" | ||
| "react-dom": ">=15", | ||
| "webpack": ">=4" |
There was a problem hiding this comment.
webpack isn't in peerDependencies to support tools like Create React App that have their own webpack. We have a version check to be sure that the user has the supported webpack version.
There was a problem hiding this comment.
if the user does not use webpack. he will see install:
warning "react-styleguidist > [email protected]" has unmet peer dependency "webpack@^2.0.0 || ^3.0.0 || ^4.0.0".
warning "react-styleguidist > [email protected]" has unmet peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "react-styleguidist > webpack-dev-server > [email protected]" has unmet peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".
if build:
Webpack is required for Styleguidist, please add it to your project:
npm install --save-dev webpack
See how to configure it for your style guide:
https://react-styleguidist.js.org/docs/webpack.html
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
I thought it was true to talk about this dependency when installing.
Ok I will remove from peer.
…react-dev-utils add webpack to peer
AndreyGladkov
force-pushed
the
up-some-deps-version
branch
from
3fc6c75
to
0169b98
Compare
sapegin
pushed a commit
that referenced
this pull request
Oct 23, 2018
## Breaking changes ### Drop webpack 3 support Webpack 3 is no longer supported, webpack 4 is the minimum required version. As a side effect you shouldn’t see any webpack warnings when you run Styleguidist. We’ve also replaced no longer maintainer uglify-es with Terser to minify production JavaScript bundle. * #1175, #1178 by @derz * #1165 by @elevatebart * #1148 by @elevatebart * #915, #1023 by @stepancar * #1180 by @AndreyGladkov
|
😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature. |
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn install shows warnings
Remote Code Execution in
react-dev-utilsAdd webpack to peerDependencies.