Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade / replace uglifyjs-webpack-plugin #1175

Closed
sapegin opened this issue Oct 16, 2018 · 1 comment
Closed

Upgrade / replace uglifyjs-webpack-plugin #1175

sapegin opened this issue Oct 16, 2018 · 1 comment
Labels
help wanted released
Milestone
8.0.0: No webpack 3

Comments

@sapegin
Copy link
Member

sapegin commented Oct 16, 2018 •
edited
Loading

uglifyjs-webpack-plugin 1.x (the version we use) uses uglify-es, which is no longer maintained. uglifyjs-webpack-plugin 2.x uses uglify-js again. We can't upgrade to this version because it'll fail on ES6 syntax, and such things shouldn't be hardcoded.

So the most promising option is to migrate to terser-webpack-plugin, which uses terser, which is a fork of unmaintained uglify-es. Both seem to be actively maintained.

We can use cache option to increase performance. Other options may be useful too.

Are there any alternatives I've missed?

Please send a pull request to the next branch.
@sapegin sapegin added this to the 9.0.0: No webpack 3 milestone Oct 16, 2018
derz added a commit to derz/react-styleguidist that referenced this issue Oct 17, 2018
@derz
Chore: replaces UglifyJS with Terser (styleguidist#1175)
52d3d58
@derz derz mentioned this issue Oct 17, 2018
Closed
sapegin pushed a commit that referenced this issue Oct 23, 2018
Changelog: 🚀
8e79531 
## Breaking changes

### Drop webpack 3 support

Webpack 3 is no longer supported, webpack 4 is the minimum required version.

As a side effect you shouldn’t see any webpack warnings when you run Styleguidist.

We’ve also replaced no longer maintainer uglify-es with Terser to minify production JavaScript bundle.

* #1175, #1178 by @derz
* #1165 by @elevatebart
* #1148 by @elevatebart
* #915, #1023 by @stepancar
* #1180 by @AndreyGladkov
@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sapegin pushed a commit that referenced this issue Nov 7, 2018
Feat: UglifyJsPlugin → TerserPlugin
37e7c54 
Replace unmaintained uglify-es with terser.

Original commit by @derz — #1178

Closes #1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted released
Projects
None yet
Milestone
8.0.0: No webpack 3
Development

No branches or pull requests
2 participants
@sapegin @styleguidist-bot