uses enum for shred type (backport #21333)

[mergify]

This is an automatic backport of pull request #21333 done by Mergify.
Cherry-pick of 57057f8 has failed:

On branch mergify/bp/v1.8/pr-21333
Your branch is up to date with 'origin/v1.8'.

You are currently cherry-picking commit 57057f8d3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.lock
	modified:   core/src/window_service.rs
	modified:   gossip/src/duplicate_shred.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/retransmit_stage.rs
	both modified:   gossip/src/cluster_info.rs
	both modified:   ledger/Cargo.toml
	both modified:   ledger/src/blockstore.rs
	both modified:   ledger/src/shred.rs

Cherry-pick of 48dfdfb has failed:

On branch mergify/bp/v1.8/pr-21333
Your branch is ahead of 'origin/v1.8' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 48dfdfb4d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/window_service.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ledger/src/blockstore.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[sakridge]

why do we need this in 1.8?

[mergify]

automerge label removed due to a CI failure

[behzadnouri]

why do we need this in 1.8?

Cluster needs to be fully on #21623 before I can safely push follow up changes; and so I am back-porting earlier changes that #21623 either depends on or will merge conflict.

[sakridge]

None of those changes sound like they should be in 1.8 either? Why wouldn’t we test on 1.9 and then wait for mainnet to be on that version?

[behzadnouri]

None of those changes sound like they should be in 1.8 either? Why wouldn’t we test on 1.9 and then wait for mainnet to be on that version?

Carl wanted the #22141 and #22139 backports so that backport of #20873 would be easier. Those changes are from back in August.

The other backports are related to shreds/erasure-coding/blockstore, which are working towards implementing:
https://discord.com/channels/428295358100013066/478692221441409024/901255427369627678

which will then generate more coding shreds than data shreds. Because there are more coding shreds than data shreds, the indices of coding shreds no longer align with data shreds and we need for example #21600 to track position of coding shreds explicitly and #21623 to track first coding index.

It will cause backward incompatibility issue if a node running master or v1.9 becomes the leader and generates more coding shreds than the data shreds, whereas the cluster does not yet have above patches to be able to digest these shreds. So we need these backports to v1.8 so that master/v1.9 is backward compatible with mainnet.

[mergify]

automerge label removed due to a CI failure

[solana-grimes]

😱 New commits were pushed while the automerge label was present.

[mergify]

automerge label removed due to a CI failure

[mergify]

automerge label removed due to a CI failure

[behzadnouri]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[mergify]

automerge label removed due to a CI failure

[codecov]

Codecov Report

Merging #22147 (c3b4b11) into v1.8 (ec970f9) will decrease coverage by 0.0%.
The diff coverage is 96.5%.

@@            Coverage Diff            @@
##             v1.8   #22147     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         459      459             
  Lines      130934   130957     +23     
=========================================
+ Hits       106835   106843      +8     
- Misses      24099    24114     +15     

[github-actions]

This PR has been automatically locked since there has not been any activity in past 14 days after it was merged.