This repository was archived by the owner on Jan 22, 2025. It is now read-only.
adds back ErasureMeta::first_coding_index field#21623
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Dec 10, 2021
Merged
adds back ErasureMeta::first_coding_index field#21623behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21623 +/- ##
=========================================
- Coverage 81.6% 81.4% -0.2%
=========================================
Files 511 511
Lines 143320 143440 +120
=========================================
- Hits 116976 116856 -120
- Misses 26344 26584 +240 |
behzadnouri
force-pushed
the
first-coding-index
branch
from
9b4b15c to
5ce0c60
Compare
carllin
reviewed
Dec 7, 2021
| self.set_index..self.set_index + num_coding | ||
| // first_coding_index == 0 may imply that the field is not populated. | ||
| // self.set_index to be backward compatible. | ||
| // TODO remove this once cluster is upgraded to always populate |
Contributor
There was a problem hiding this comment.
Might be good to create an issue as a reminder to track this and other TODOs
Contributor
Author
There was a problem hiding this comment.
Yeah, already have draft follow up changes.
There is no harm in keeping this code as is, until those upcoming changes are ready to go.
I just need to merge this commit in an earlier release to avoid any compatibility issues.
carllin
reviewed
Dec 7, 2021
Comment on lines
+281
to
+285
| let first_coding_index = if self.first_coding_index == 0 { | ||
| self.set_index | ||
| } else { | ||
| self.first_coding_index | ||
| }; |
Contributor
There was a problem hiding this comment.
nice, this was pretty subtle to maintain backwards compatibility
solana-labs#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent.
behzadnouri
force-pushed
the
first-coding-index
branch
from
5ce0c60 to
282f10d
Compare
carllin
approved these changes
Dec 10, 2021
mergify Bot
added a commit
that referenced
this pull request
Dec 10, 2021
#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
mergify Bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) # Conflicts: # ledger/src/blockstore.rs
mergify Bot
added a commit
that referenced
this pull request
Feb 3, 2022
…2912) * adds back ErasureMeta::first_coding_index field (#21623) #16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) # Conflicts: # ledger/src/blockstore.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#16646
removed first_coding_index since the field is currently redundant and
always equal to fec_set_index.
However, with upcoming changes to erasure coding schema, this will no
longer be the same as fec_set_index and so requires a dedicated field to
represent.
Summary of Changes
ErasureMeta::first_coding_index.ErasureMetaconstruction andfec_set_index.