This repository was archived by the owner on Jan 22, 2025. It is now read-only.
adds back position field to coding-shred-header#21600
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Dec 5, 2021
Merged
adds back position field to coding-shred-header#21600behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
solana-labs#17004 removed position field from coding-shred-header because as it stands the field is redundant and unused. However, with the upcoming changes to erasure coding schema this field will no longer be redundant and needs to be populated.
Codecov Report
@@ Coverage Diff @@
## master #21600 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 509 509
Lines 142145 142143 -2
=========================================
- Hits 116047 116019 -28
- Misses 26098 26124 +26 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 5, 2021
#17004 removed position field from coding-shred-header because as it stands the field is redundant and unused. However, with the upcoming changes to erasure coding schema this field will no longer be redundant and needs to be populated. (cherry picked from commit cd17f63) # Conflicts: # core/src/window_service.rs # ledger/src/blockstore.rs # ledger/src/shred.rs
mergify Bot
added a commit
that referenced
this pull request
Dec 5, 2021
#17004 removed position field from coding-shred-header because as it stands the field is redundant and unused. However, with the upcoming changes to erasure coding schema this field will no longer be redundant and needs to be populated. (cherry picked from commit cd17f63) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
mergify Bot
added a commit
that referenced
this pull request
Dec 5, 2021
…1619) * adds back position field to coding-shred-header (#21600) #17004 removed position field from coding-shred-header because as it stands the field is redundant and unused. However, with the upcoming changes to erasure coding schema this field will no longer be redundant and needs to be populated. (cherry picked from commit cd17f63) # Conflicts: # core/src/window_service.rs # ledger/src/blockstore.rs # ledger/src/shred.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
jbiseda
pushed a commit
to jbiseda/solana
that referenced
this pull request
Dec 6, 2021
solana-labs#17004 removed position field from coding-shred-header because as it stands the field is redundant and unused. However, with the upcoming changes to erasure coding schema this field will no longer be redundant and needs to be populated.
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…ana-labs#21600) (solana-labs#21619)" This reverts commit 6d1e128.
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…port solana-labs#21600) (solana-labs#21619)"" This reverts commit c901227.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#17004
removed position field from coding-shred-header because as it stands the
field is redundant and unused.
However, with the upcoming changes to erasure coding schema this field
will no longer be redundant and needs to be populated.
Summary of Changes