This repository was archived by the owner on Jan 22, 2025. It is now read-only.
renames solana_runtime::vote_account::VoteAccount and makes it private (backport #19153)#22141
Merged
mergify[bot] merged 3 commits intov1.8from Dec 28, 2021
Merged
renames solana_runtime::vote_account::VoteAccount and makes it private (backport #19153)#22141mergify[bot] merged 3 commits intov1.8from
mergify[bot] merged 3 commits intov1.8from
Conversation
VoteAccount is an implementation detail, and should not be public. Only ArcVoteAccount is the public type. (cherry picked from commit 1403eae) # Conflicts: # runtime/src/vote_account.rs
Rename: VoteAccount -> VoteAccountInner # the private type ArcVoteAccount -> VoteAccount # the public type (cherry picked from commit 00e5e12) # Conflicts: # core/src/progress_map.rs # ledger/src/blockstore_processor.rs # ledger/src/staking_utils.rs # runtime/src/bank.rs # runtime/src/epoch_stakes.rs # runtime/src/serde_snapshot/tests.rs # runtime/src/stakes.rs # runtime/src/vote_account.rs
Contributor
Author
|
automerge label removed due to a CI failure |
f359924 to
4d89669
Compare
Contributor
|
😱 New commits were pushed while the automerge label was present. |
Contributor
Author
|
automerge label removed due to a CI failure |
4d89669 to
58a6bda
Compare
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
|
@carllin I will take care of merge conflicts |
58a6bda to
b0a978f
Compare
b0a978f to
60256bc
Compare
Contributor
|
😱 New commits were pushed while the automerge label was present. |
Codecov Report
@@ Coverage Diff @@
## v1.8 #22141 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 459 459
Lines 130629 130618 -11
=======================================
+ Hits 106546 106551 +5
+ Misses 24083 24067 -16 |
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19153 done by Mergify.
Cherry-pick of 1403eae has failed:
Cherry-pick of 00e5e12 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com