This repository was archived by the owner on Jan 22, 2025. It is now read-only.
implements copy-on-write for vote-accounts (backport #19362)#22139
Merged
mergify[bot] merged 1 commit intov1.8from Dec 28, 2021
Merged
implements copy-on-write for vote-accounts (backport #19362)#22139mergify[bot] merged 1 commit intov1.8from
mergify[bot] merged 1 commit intov1.8from
Conversation
Contributor
Author
|
automerge label removed due to a CI failure |
51bdf48 to
c6142ed
Compare
c6142ed to
774112d
Compare
Contributor
|
😱 New commits were pushed while the automerge label was present. |
774112d to
4370c45
Compare
Contributor
|
😱 New commits were pushed while the automerge label was present. |
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
|
@carllin I will take care of merge conflicts |
Contributor
|
@Mergifyio rebase |
Contributor
Author
❌ Base branch update has failedDetailsGit reported the following error: err-code: 35B49 |
Bank::vote_accounts redundantly clones vote-accounts HashMap even though an immutable reference will suffice: https://github.com/solana-labs/solana/blob/95c998a19/runtime/src/bank.rs#L5174-L5186 This commit implements copy-on-write semantics for vote-accounts by wrapping the underlying HashMap in Arc<...>.
4370c45 to
b814047
Compare
Codecov Report
@@ Coverage Diff @@
## v1.8 #22139 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 459 459
Lines 130618 130661 +43
=======================================
+ Hits 106548 106603 +55
+ Misses 24070 24058 -12 |
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19362 done by Mergify.
Cherry-pick of 8ad52fa has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com