This repository was archived by the owner on Jan 22, 2025. It is now read-only.
ClusterInfoVoteListener send only missing votes to BankingStage#20873
Merged
carllin merged 13 commits intosolana-labs:masterfrom Nov 18, 2021
Merged
ClusterInfoVoteListener send only missing votes to BankingStage#20873carllin merged 13 commits intosolana-labs:masterfrom
carllin merged 13 commits intosolana-labs:masterfrom
Conversation
carllin
force-pushed
the
FixVotes
branch
4 times, most recently
from
2fb1441 to
faed3f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #20873 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 501 501
Lines 140699 140911 +212
=========================================
+ Hits 114751 114903 +152
- Misses 25948 26008 +60 |
carllin
force-pushed
the
FixVotes
branch
8 times, most recently
from
207754e to
ac74b2c
Compare
carllin
commented
Oct 31, 2021
|
|
||
| #[test] | ||
| #[serial] | ||
| fn test_votes_land_in_fork_during_long_partition() { |
Contributor
Author
There was a problem hiding this comment.
Local cluster test fails without these changes, passes with these fixes
tao-stones
reviewed
Nov 4, 2021
mergify
Bot
dismissed
tao-stones’s stale review
Pull request has been modified.
carllin
force-pushed
the
FixVotes
branch
5 times, most recently
from
2b35245 to
86c903c
Compare
…ill_be_processing_txs
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…ge (solana-labs#20873)" This reverts commit f644729.
mergify Bot
pushed a commit
that referenced
this pull request
Dec 28, 2021
(cherry picked from commit b30c94c) # Conflicts: # core/src/cluster_info_vote_listener.rs # core/src/verified_vote_packets.rs # gossip/src/cluster_info.rs # local-cluster/tests/local_cluster.rs # runtime/src/bank.rs
carllin
added a commit
that referenced
this pull request
Dec 28, 2021
(cherry picked from commit b30c94c) # Conflicts: # core/src/cluster_info_vote_listener.rs # core/src/verified_vote_packets.rs # gossip/src/cluster_info.rs # local-cluster/tests/local_cluster.rs # runtime/src/bank.rs
carllin
added a commit
that referenced
this pull request
Dec 30, 2021
(cherry picked from commit b30c94c) # Conflicts: # core/src/cluster_info_vote_listener.rs # core/src/verified_vote_packets.rs # gossip/src/cluster_info.rs # local-cluster/tests/local_cluster.rs # runtime/src/bank.rs
mergify Bot
added a commit
that referenced
this pull request
Dec 30, 2021
…port #20873) (#22135) * ClusterInfoVoteListener send only missing votes to BankingStage (#20873) (cherry picked from commit b30c94c) # Conflicts: # core/src/cluster_info_vote_listener.rs # core/src/verified_vote_packets.rs # gossip/src/cluster_info.rs # local-cluster/tests/local_cluster.rs # runtime/src/bank.rs * Resolve conflicts * Remove Select * Fixup tests Co-authored-by: carllin <carl@solana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Only send newer votes on the same fork, in the right order to BankingStage
Fixes #