Rewrite stake accounts for clear migration by ryoqun · Pull Request #13461 · solana-labs/solana

ryoqun · 2020-11-07T15:57:15Z

Problem

~~this is very much still draft.~~ this is done job!

bugs (those were fixed by #13357 and #13358) created many kinds of bad stake accounts.

Summary of Changes

~~todo: add test.~~ done

Fixes #

codecov · 2020-11-08T13:26:48Z

Codecov Report

Merging #13461 (929e217) into master (acc40b1) will increase coverage by 0.0%.
The diff coverage is 98.9%.

@@           Coverage Diff            @@
##           master   #13461    +/-   ##
========================================
  Coverage    82.2%    82.2%            
========================================
  Files         378      378            
  Lines       91258    91433   +175     
========================================
+ Hits        75065    75244   +179     
+ Misses      16193    16189     -4

ryoqun · 2020-11-16T21:09:22Z

add another feature gate specifically for this.

ryoqun · 2020-11-17T16:00:19Z

add another feature gate specifically for this.

@CriesofCarrots Also, I noticed that this calculation could be off without rewriting all rent_exempt_reserve and only enabling stake_program_v2. Because stake account size and rent exempt reserve isn't guaranteed to be in sync at the moment unfortunately, maybe?:

solana/programs/stake/src/stake_state.rs

Lines 902 to 906 in 3827739

    
           let split_rent_exempt_reserve = calculate_split_rent_exempt_reserve( 
        
               meta.rent_exempt_reserve, 
        
               self.data_len()? as u64, 
        
               split.data_len()? as u64, 
        
           );

CriesofCarrots

Fantastic, this seems really close! A couple nits, and I just have a couple quick questions about the feature activation (probably I'm missing something).

CriesofCarrots

Thanks for all the care taken on this. Lgtm!

ryoqun · 2020-11-19T19:43:29Z

finally! I've finished to test this locally extensively with mainnet-beta snapshot. Merging this shortly.

* Reduce overage stake by rewritng stake accounts * Write tests and finish implemention * Create and use new feature gate * Clean up logging * Fix typo * Simplify enable_rewrite_stake * Fix typo... * Even simplify gating * Add metrics (cherry picked from commit 43d5e47)

* Reduce overage stake by rewritng stake accounts * Write tests and finish implemention * Create and use new feature gate * Clean up logging * Fix typo * Simplify enable_rewrite_stake * Fix typo... * Even simplify gating * Add metrics (cherry picked from commit 43d5e47) Co-authored-by: Ryo Onodera <ryoqun@gmail.com>

Lichtso · 2023-05-24T11:55:08Z

Can we remove the function Bank::reconfigure_token2_native_mint() now?

mvines · 2023-05-25T06:09:40Z

Can we remove the function Bank::reconfigure_token2_native_mint() now?

Did you mean to necropost here? Short answer is maybe! Worth exploring

Lichtso · 2023-05-25T06:52:41Z

Yes, I meant to post. Just saw the function added in this PR still being around as I am working on the feature set transition for the LoadedPrograms cache.

ryoqun · 2023-05-26T01:20:49Z

Yes, I meant to post. Just saw the function added in this PR still being around as I am working on the feature set transition for the LoadedPrograms cache.

@Lichtso hmm? i think reconfigure_token2_native_mint is added by a different pr: #11966 (comment), not this pr..

anyway, i also think it's okay to remove that function. (thanks for feature cleanup prs by the way)

ryoqun added v1.3 labels Nov 7, 2020

ryoqun requested a review from CriesofCarrots November 7, 2020 15:57

ryoqun commented Nov 7, 2020

View reviewed changes

Comment thread programs/stake/src/stake_state.rs Outdated

ryoqun commented Nov 7, 2020

View reviewed changes

Comment thread runtime/src/bank.rs Outdated

ryoqun added CI Pull Request is ready to enter CI and removed CI Pull Request is ready to enter CI labels Nov 7, 2020

ryoqun commented Nov 7, 2020

View reviewed changes

Comment thread programs/stake/src/stake_state.rs Outdated

ryoqun added the CI Pull Request is ready to enter CI label Nov 7, 2020

solana-grimes removed the CI Pull Request is ready to enter CI label Nov 7, 2020

ryoqun force-pushed the reduce-overage-stake branch from 62e4cc9 to 3abd834 Compare November 8, 2020 14:10

ryoqun commented Nov 10, 2020

View reviewed changes

Comment thread runtime/src/bank.rs Outdated

ryoqun commented Nov 10, 2020

View reviewed changes

Comment thread runtime/src/genesis_utils.rs

ryoqun mentioned this pull request Nov 10, 2020

Fix slow/stuck unstaking due to toggling in epoch #13501

Merged

ryoqun force-pushed the reduce-overage-stake branch 2 times, most recently from c7f7eb2 to 397d3c5 Compare November 15, 2020 04:07

ryoqun mentioned this pull request Nov 16, 2020

Reject faked stake/vote accounts in stake mgmt. #13615

Merged

CriesofCarrots reviewed Nov 16, 2020

View reviewed changes

CriesofCarrots mentioned this pull request Nov 17, 2020

Remove stake split overflow opportunities #13649

Merged

ryoqun force-pushed the reduce-overage-stake branch from d3593d4 to 63e87aa Compare November 17, 2020 18:02

ryoqun mentioned this pull request Nov 17, 2020

Fix fragile tests in prep of stake rewrite pr #13654

Merged

ryoqun force-pushed the reduce-overage-stake branch 3 times, most recently from a2294db to 3766af0 Compare November 18, 2020 00:52

ryoqun added v1.4 and removed v1.4 labels Nov 18, 2020

ryoqun force-pushed the reduce-overage-stake branch from 3766af0 to 39fb917 Compare November 18, 2020 01:00

ryoqun marked this pull request as ready for review November 18, 2020 16:53

ryoqun force-pushed the reduce-overage-stake branch from f2c00ec to c18f84a Compare November 18, 2020 16:56

ryoqun changed the title ~~Reduce overage stake by rewritng stake accounts~~ Rewritng stake accounts for clear migration Nov 18, 2020

ryoqun changed the title ~~Rewritng stake accounts for clear migration~~ Rewrite stake accounts for clear migration Nov 18, 2020

CriesofCarrots reviewed Nov 18, 2020

View reviewed changes

Comment thread ledger-tool/src/main.rs Outdated

Comment thread runtime/src/bank.rs Outdated

Comment thread runtime/src/bank.rs Outdated

Comment thread runtime/src/bank.rs Outdated

ryoqun added 7 commits November 19, 2020 12:54

Reduce overage stake by rewritng stake accounts

ddd51ae

Write tests and finish implemention

643bc98

Create and use new feature gate

cfa4f54

Clean up logging

aa1ea62

Fix typo

c655daf

Simplify enable_rewrite_stake

4410a35

Fix typo...

1faaf81

ryoqun force-pushed the reduce-overage-stake branch from cf6fc9c to 1faaf81 Compare November 19, 2020 04:13

ryoqun added 2 commits November 19, 2020 13:27

Even simplify gating

a35d8de

Add metrics

929e217

CriesofCarrots approved these changes Nov 19, 2020

View reviewed changes

ryoqun merged commit 43d5e47 into solana-labs:master Nov 19, 2020

mergify Bot mentioned this pull request Nov 19, 2020

Rewrite stake accounts for clear migration (bp #13461) #13705

Merged

ryoqun mentioned this pull request Feb 11, 2022

Refactor and use MINIMUM_STAKE_DELEGATION constant #22663

Merged

Lichtso mentioned this pull request May 25, 2023

Cleanup - Bank::reconfigure_token2_native_mint() #31817

Merged

Conversation

ryoqun commented Nov 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Summary of Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Nov 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

ryoqun commented Nov 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryoqun commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CriesofCarrots left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CriesofCarrots left a comment

Choose a reason for hiding this comment

Uh oh!

ryoqun commented Nov 19, 2020

Uh oh!

Lichtso commented May 24, 2023

Uh oh!

mvines commented May 25, 2023

Uh oh!

Lichtso commented May 25, 2023

Uh oh!

ryoqun commented May 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ryoqun commented Nov 7, 2020 •

edited

Loading

codecov Bot commented Nov 8, 2020 •

edited

Loading

ryoqun commented Nov 16, 2020 •

edited

Loading

ryoqun commented Nov 17, 2020 •

edited

Loading