This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Ensure that the spl-token 2 native mint account is owned by the spl-token 2 program#11966
Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom Sep 1, 2020
Merged
Ensure that the spl-token 2 native mint account is owned by the spl-token 2 program#11966mergify[bot] merged 1 commit intosolana-labs:masterfrom
mergify[bot] merged 1 commit intosolana-labs:masterfrom
Conversation
mvines
force-pushed
the
spl
branch
3 times, most recently
from
880818a to
73d6df4
Compare
Contributor
Author
|
@ryoqun - I'd appreciate your careful eye here too. We want to ship this to 1.2 ASAP |
mvines
force-pushed
the
spl
branch
2 times, most recently
from
4f4d94e to
2e82dd6
Compare
mvines
commented
Sep 1, 2020
mvines
commented
Sep 1, 2020
mvines
force-pushed
the
spl
branch
4 times, most recently
from
3ead8c6 to
d993400
Compare
mvines
commented
Sep 1, 2020
jackcmay
previously approved these changes
Sep 1, 2020
mergify
Bot
dismissed
jackcmay’s stale review
Pull request has been modified.
mvines
force-pushed
the
spl
branch
3 times, most recently
from
f46b450 to
10b17ca
Compare
ryoqun
reviewed
Sep 1, 2020
ryoqun
reviewed
Sep 1, 2020
ryoqun
reviewed
Sep 1, 2020
ryoqun
previously approved these changes
Sep 1, 2020
Contributor
ryoqun
left a comment
ryoqun
left a comment
There was a problem hiding this comment.
lgtm with nits.
I also lightly tested this locally. there is no problem.
However, ci is failing...
Contributor
Author
Sorry, was trying to get this wrapped up before 🛏️. There's a number of tests that get angry about the new mint account that gets added automatically when in development operating mode. Flipping those tests to use the stable operating mode makes them happy again |
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
Codecov Report
@@ Coverage Diff @@
## master #11966 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 333 333
Lines 78106 78175 +69
=======================================
+ Hits 64151 64237 +86
+ Misses 13955 13938 -17 |
ryoqun
reviewed
May 26, 2023
| self.set_compute_budget(compute_budget); | ||
| } | ||
|
|
||
| fn reconfigure_token2_native_mint(self: &mut Bank) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped