This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix fragile tests in prep of stake rewrite pr#13654
Merged
ryoqun merged 7 commits intosolana-labs:masterfrom Nov 20, 2020
Merged
Fix fragile tests in prep of stake rewrite pr#13654ryoqun merged 7 commits intosolana-labs:masterfrom
ryoqun merged 7 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13654 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 378 378
Lines 91310 91320 +10
=========================================
+ Hits 75023 75028 +5
- Misses 16287 16292 +5 |
CriesofCarrots
previously approved these changes
Nov 18, 2020
mergify
Bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
mergify Bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
* Fix fragile tests in prep of stake rewrite pr * Restore BOOTSTRAP_VALIDATOR_LAMPORTS where appropriate * Further clean up * Further clean up * Aligh with other call site change * Remove false warn! * fix ci! (cherry picked from commit b74d7b5)
Contributor
Author
|
Strictly speaking, #13461 didn't needed this. But, anyway I merged this because it's nice to have. Also, backported to v1.4 because this is test only change (very low risk) and to avoid future backport churn for inflation changes (arguably, essential). |
mergify Bot
added a commit
that referenced
this pull request
Nov 20, 2020
* Fix fragile tests in prep of stake rewrite pr * Restore BOOTSTRAP_VALIDATOR_LAMPORTS where appropriate * Further clean up * Further clean up * Aligh with other call site change * Remove false warn! * fix ci! (cherry picked from commit b74d7b5) Co-authored-by: Ryo Onodera <ryoqun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Existing tests are creating bad stake accounts which are less than
rent_exempt_reserve, notably only42lamports... #13461 will forbid such accounts. So, fix tests first.Summary of Changes
Not ideal, but just hacky mindless replacement:
BOOTSTRAP_VALIDATOR_LAMPORTS=>bootstrap_validator_lamports()Fixes #