This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Cleanup - Bank::reconfigure_token2_native_mint()#31817
Merged
Lichtso merged 1 commit intosolana-labs:masterfrom Jun 7, 2023
Merged
Cleanup - Bank::reconfigure_token2_native_mint()#31817Lichtso merged 1 commit intosolana-labs:masterfrom
Bank::reconfigure_token2_native_mint()#31817Lichtso merged 1 commit intosolana-labs:masterfrom
Conversation
Lichtso
force-pushed
the
cleanup/reconfigure_token2_native_mint
branch
from
e86cbbf to
20bb855
Compare
Contributor
|
I suspect unfortunately that this change would break SPL Token wrapped SOL on |
Contributor
Author
|
Can't we adjust the genesis setup to account for that? |
Contributor
|
Yep I think that'd work! |
Lichtso
force-pushed
the
cleanup/reconfigure_token2_native_mint
branch
from
20bb855 to
abb7261
Compare
Lichtso
force-pushed
the
cleanup/reconfigure_token2_native_mint
branch
from
abb7261 to
dbe9864
Compare
Codecov Report
@@ Coverage Diff @@
## master #31817 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 762 762
Lines 207721 207670 -51
=========================================
- Hits 170137 170095 -42
+ Misses 37584 37575 -9 |
Contributor
|
Latest iteration looks pretty good to me |
mvines
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The epochs for this transition code have long passed, so it can be cleaned up.
See #13461 (comment) .
Summary of Changes
Removes
Bank::reconfigure_token2_native_mint().