This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove stake split overflow opportunities#13649
Merged
CriesofCarrots merged 1 commit intosolana-labs:masterfrom Nov 17, 2020
Merged
Remove stake split overflow opportunities#13649CriesofCarrots merged 1 commit intosolana-labs:masterfrom
CriesofCarrots merged 1 commit intosolana-labs:masterfrom
Conversation
Contributor
Author
|
CI failure is unrelated, fixed by #13645 |
mergify Bot
pushed a commit
that referenced
this pull request
Nov 17, 2020
(cherry picked from commit a7bed62)
mergify Bot
pushed a commit
that referenced
this pull request
Nov 17, 2020
(cherry picked from commit a7bed62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If we upgrade to stake-program-v2 before performing the accounts rewrite (#13461), there are a couple opportunities for overflow on split operations against accounts where
rent_exempt_reserve > self.lamports().Summary of Changes
Fix them