This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix stake redelegate#13358
Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom Nov 6, 2020
Merged
Conversation
Contributor
Author
|
Do you have time to take a peek at one more, @rwalker-com? 🙏 |
rwalker-apple
approved these changes
Nov 3, 2020
rwalker-com
reviewed
Nov 3, 2020
rwalker-com
reviewed
Nov 3, 2020
rwalker-com
approved these changes
Nov 3, 2020
Contributor
rwalker-com
left a comment
rwalker-com
left a comment
There was a problem hiding this comment.
great job closing a hole you can throw a cat through
CriesofCarrots
previously approved these changes
Nov 3, 2020
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
I'll take another look when you push your test changes, but fix lgtm!
It'll be good to get another winky comment in the code base as well ;)
t-nelson
force-pushed
the
fix-stake-redelegate
branch
from
095700c to
95b0d83
Compare
mergify
Bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
Contributor
Author
|
Review's been addressed! |
Codecov Report
@@ Coverage Diff @@
## master #13358 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 378 378
Lines 89990 90037 +47
=======================================
+ Hits 73862 73914 +52
+ Misses 16128 16123 -5 |
Contributor
|
This will need rebasing on #13394 (make sure it goes in stake_state.rs, as opposed to the legacy mod) |
t-nelson
force-pushed
the
fix-stake-redelegate
branch
from
95b0d83 to
87d661f
Compare
Contributor
Author
|
Rebased on #13394 |
t-nelson
added
automerge
This was referenced Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Re-delegating a formerly delegated, but currently deactivated stake account, does not consider changes to the account balance
Summary of Changes
Use the current account balance rather than the previous delegation amount
WIP until activation is coordinated with #13357