Repository navigation
chore: bump versions for v1.5.0 release - #1665
Merged
Merged
Conversation
slin1237
requested review from
CatherineSue,
XinyueZhang369,
gongwei-130,
key4ng,
llfl,
tonyluj,
whybeyoung,
zhaowenzi and
zhoug9127
as code owners
June 11, 2026 07:45
github-actions
Bot
added
tokenizer
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (23)
📝 WalkthroughWalkthroughThis PR updates engine Docker workflow defaults (vLLM → v0.22.1, sglang → v0.5.12.post1, TensorRT-LLM → 1.3.0rc18), and synchronizes version bumps from v1.4.1 → v1.5.0 across workspace dependencies, crate manifests, bindings, model_gateway, and Helm chart. Changesv1.5.0 Release Version Synchronization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the version numbers across the workspace, bumping the main project and several bindings to version 1.5.0, while also updating internal crate dependencies to their latest versions. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
👋 The PR description doesn't fully follow
Please update the PR description so reviewers have the context they need. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a095470cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
slin1237
force-pushed
the
chore/release-v1.5.0
branch
from
June 11, 2026 16:56
3a09547 to
c10ad44
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly-engine-docker.yml:
- Around line 46-53: Check that the container tags used in the workflow resolve
in their registries: verify base_image_ref entries vllm/vllm-openai:v0.22.1,
lmsysorg/sglang:v0.5.12.post1 and nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc18
actually exist (especially the TensorRT-LLM tag) by inspecting Docker Hub and
NVIDIA NGC release/tag pages or using docker/registry manifest inspect; if any
tag (e.g., nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc18) is missing, update the
workflow to a valid tag or engine (references: base_image_ref and engine_ver
lines and the engine identifiers sglang/trtllm/vllm) and add a brief comment
documenting the registry source used to confirm the replacement.
In @.github/workflows/release-vllm-docker.yml:
- Line 63: The matrix base_image list is referencing non-existent vLLM Docker
tags; update the base_image expression (the base_image variable and the
inputs.base_image_ref usage) to use the exact published Docker tag names or add
a validation/fallback: run a manifest check for each candidate tag and only
include tags that respond OK, otherwise fall back to inputs.base_image_ref (or a
known-good default). Ensure the change updates the inline array used in the
base_image expression so the workflow only selects tags that exist.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b88c6d16-2674-49dc-9ad1-e7c1645c668f
📒 Files selected for processing (23)
.github/workflows/nightly-engine-docker.yml.github/workflows/release-sglang-docker.yml.github/workflows/release-trtllm-docker.yml.github/workflows/release-vllm-docker.ymlCargo.tomlbindings/golang/Cargo.tomlbindings/python/Cargo.tomlbindings/python/pyproject.tomlcrates/auth/Cargo.tomlcrates/data_connector/Cargo.tomlcrates/grpc_client/Cargo.tomlcrates/kv_index/Cargo.tomlcrates/mcp/Cargo.tomlcrates/mesh/Cargo.tomlcrates/multimodal/Cargo.tomlcrates/protocols/Cargo.tomlcrates/reasoning_parser/Cargo.tomlcrates/tokenizer/Cargo.tomlcrates/tool_parser/Cargo.tomlcrates/wasm/Cargo.tomlcrates/workflow/Cargo.tomldeploy/helm/smg/Chart.yamlmodel_gateway/Cargo.toml
Workspace crates, bindings, helm chart, and release workflows bumped per make check-versions (smg 1.4.1 -> 1.5.0 plus per-crate minor/patch bumps). Also refresh the engine base images in the engine release and nightly docker workflows to the versions CI now tests against: - sglang: lmsysorg/sglang v0.5.10 -> v0.5.12.post1 (#1662) - vllm: vllm-openai matrix v0.19.0/v0.18.0/v0.17.0 -> v0.22.1/v0.21.0/v0.20.0 (#1625) - trtllm: NGC release matrix 1.3.0rc10/rc9/rc8 -> rc18/rc17/rc16 (#1663) All base image tags verified published (Docker Hub / nvcr.io). Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
slin1237
force-pushed
the
chore/release-v1.5.0
branch
from
June 11, 2026 20:14
c10ad44 to
e735b3d
Compare
This was referenced Aug 24, 2026
This was referenced Sep 24, 2026
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Version bumps for the SMG v1.5.0 release, generated by
make check-versionsagainst tagv1.4.1, plus a refresh of the engine base images in the engine release/nightly Docker workflows (whichcheck-versionsdoes not cover — it only syncs the SMG version refs).Changes
Workspace versions (per
check-versionsproposed fixes, all applied):smg1.4.1 → 1.5.0; synced:smg-python,smg-golang, pythonpyproject.toml, helm chart, and the SMG refs inrelease-{sglang,vllm,trtllm}-docker.ymlopenai-protocol1.8.0,reasoning-parser1.3.0,tool-parser1.3.0,llm-tokenizer1.4.0,smg-auth1.2.0,smg-mcp2.3.0,kv-index1.3.0,data-connector2.3.0,llm-multimodal1.6.0,smg-mesh1.4.0,smg-grpc-client1.6.0wfaas1.0.4,smg-wasm1.1.1Engine base images — release workflows now build on the same engine versions CI tests against:
release-sglang-docker.ymllmsysorg/sglang:v0.5.10lmsysorg/sglang:v0.5.12.post1(#1662)release-vllm-docker.yml(3-version matrix)v0.19.0/v0.18.0/v0.17.0v0.22.1/v0.21.0/v0.20.0(#1625)release-trtllm-docker.yml(3-version matrix)1.3.0rc10/rc9/rc81.3.0rc18/rc17/rc16(#1663)nightly-engine-docker.ymlengine_vertagsTest Plan
make check-versionsre-run after applying: "All versions consistent." (14 crates + 2 Python packages reconciled, 0 issues)lmsysorg/sglang:v0.5.12.post1(Docker Hub 200),vllm/vllm-openai:{v0.22.1,v0.21.0,v0.20.0}(Docker Hub 200),nvcr.io/nvidia/tensorrt-llm/release:{1.3.0rc16,rc17,rc18}(NGC tags list)Cargo.lockis gitignored in this repo (same as the v1.4.1 release PR chore: bump versions for v1.4.1 release #1080); workspace lock refresh happens at build timeSummary by CodeRabbit