Repository navigation
chore: bump versions for v1.8.0 release - #1938
Conversation
slin1237
added
tokenizer
slin1237
added
reasoning-parser
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThis release-preparation change updates Docker workflow SMG defaults from v1.7.0 to v1.8.0 and synchronizes Rust, Python, gRPC service, and Helm package metadata with the new release versions. ChangesRelease version alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a series of version bumps across the workspace dependencies, crate packages, language bindings (Go and Python), and the Helm chart, upgrading the core gateway version from 1.7.0 to 1.8.0. There are no review comments to evaluate, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
👋 The PR description doesn't fully follow
Please update the PR description so reviewers have the context they need. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 535762640a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [project] | ||
| name = "smg" | ||
| version = "1.7.0" | ||
| version = "1.8.0" |
There was a problem hiding this comment.
When this version bump lands on main, .github/workflows/release-tokenspeed-docker.yml also runs because it watches bindings/python/pyproject.toml, but that workflow still falls back to smg_commit: ... 'v1.7.0' while _build-engine-image.yml derives the image tag from the checked-out pyproject version. The result is a 1.8.0-tokenspeed-tml image that is built from SMG v1.7.0 source, unlike the other engine images updated in this commit.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
5357626 to
032a9c2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 032a9c22fe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| version = "0.7.0" | ||
| description = "SMG gRPC servicer implementations for LLM inference engines (vLLM, MLX, TokenSpeed, SGLang)" | ||
| requires-python = ">=3.10" | ||
| dependencies = [ |
There was a problem hiding this comment.
Publishing this version bump from main changes only grpc_servicer/pyproject.toml, so the .github/workflows/release-grpc.yml detector leaves proto=false because it only flips when crates/grpc_client/python/pyproject.toml changes, and uploads smg-grpc-servicer==0.7.0 without a new smg-grpc-proto. Since TokenSpeed GetTokenizer was added to tokenspeed_scheduler.proto after the current proto package version was assigned, and the server registers through tokenspeed_scheduler_pb2_grpc.add_TokenSpeedSchedulerServicer_to_server, users can satisfy the unchanged smg-grpc-proto>=0.4.13 floor with generated stubs that do not register that RPC, so remote tokenizer loading for TokenSpeed is still reported as unimplemented. Please bump the proto package and raise this dependency floor in the same release.
Useful? React with 👍 / 👎.
2 participants
Description
Version bumps for the SMG v1.8.0 release, generated by
make check-versionsagainst tagv1.7.0.This is a version-bump-only release. Engine base images are unchanged; the Docker workflow changes only update SMG references from
v1.7.0tov1.8.0.Changes
smg1.7.0 -> 1.8.0openai-protocol1.9.0 -> 1.10.0reasoning-parser1.4.0 -> 1.5.0tool-parser1.4.0 -> 1.5.0llm-tokenizer1.4.2 -> 1.5.0llm-multimodal1.7.1 -> 1.8.0smg-grpc-client1.8.0 -> 1.9.0smg-grpc-servicer0.6.0 -> 0.7.0smg-grpc-protowas already bumped to 0.4.14Test Plan
make check-versions: All versions consistentgit diff --cached --checkCargo.lockis gitignored and refreshes at build timeSummary by CodeRabbit