Repository navigation
chore(release): bump versions for v1.11.0 - #2670
Conversation
Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
GenerateComplete.media_identity (field 15) landed after 0.4.21 was cut, so the wheel on PyPI does not carry it and the servicer's descriptor guard leaves the prefill media identity relay off for anyone installing from PyPI. The servicer has sixteen unpublished commits since 0.12.0. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 SummarySummary by CodeRabbit
WalkthroughPackage and dependency versions are updated across the workspace. Docker release defaults and Helm chart metadata move to v1.11.0, and the tier2 crate publication matrix adds ChangesSMG release updates
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The release metadata is aligned, and no actionable issue remains before normal release checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Full review of the v1.11.0 release PR: version bumps are consistent across workspace pins, crate manifests, Cargo.lock, bindings, Helm chart and Docker workflows; the smg-external-router tier-2 placement is correct (all its workspace deps are tier 1); the gRPC PyPI workflow publishes proto before servicer; and no unbumped published crate has source changes since v1.10.1. One 🟡 nit on the servicer's proto pin comment.
Description
Problem
225 commits have landed since
v1.10.1. The release checker also has no entry for the newsmg-external-routercrate, whichsmgdepends on, so the tier-4 publish ofsmgwould fail on crates.io. And the gRPC Python packages are stale on PyPI:smg-grpc-servicer0.12.0 predates sixteen servicer commits, and thesmg-grpc-proto0.4.21 wheel was cut beforeGenerateComplete.media_identity(field 15, #2627) was added, so a servicer installed from PyPI runs with the prefill media-identity relay off.Solution
Apply the version bumps the release checker proposes against
v1.10.1withVERSION_OVERRIDE=1.11.0, refresh the workspace pins andCargo.lock, addsmg-external-routerto tier 2 of the crates workflow, and bump the proto and servicer packages so the PyPI workflow republishes them.Changes
smg1.10.1 → 1.11.0, and the same version for the Python and Go bindings, the Helm chart (versionandappVersion) and the three engine Docker release workflows.openai-protocol1.14.0,reasoning-parser1.8.0,tool-parser1.8.0,llm-tokenizer1.8.0,kv-index1.5.0,llm-multimodal1.12.0,smg-grpc-client1.13.0,engine-zmq-client0.2.0,smg-mcp2.3.4,openapi-gen0.2.0. New crates stay at their initial versions (smg-radix-tree,smg-external-router,smg-rl0.1.0).Cargo.tomldependency pins andCargo.lockupdated to match.smg-grpc-proto0.4.21 → 0.4.22 andsmg-grpc-servicer0.12.0 → 0.13.0 withsmg-grpc-proto>=0.4.22. Merging triggers the gRPC PyPI workflow, which publishes the proto before the servicer..github/workflows/release-crates.yml:smg-external-routeradded to tier 2 (its workspace dependencies areopenai-protocol,data-connectorandsmg-mcp, all tier 1). The other tiers were checked against the workspace dependency graph and need no change.On the
!commitrefactor(discovery)!: split worker reconciliation and mesh-router discovery(#2532) changes the Rust API of thesmgcrate (service_discovery::ServiceDiscoveryConfig,PodInfo,start_service_discovery,server::ServerConfig). The checker maps that marker to a major bump. This release ships it as a minor on purpose: the only consumer of those items anywhere is the in-repo Python binding, which #2532 updated in the same change; crates.io lists no reverse dependencies ofsmg; and the CLI, bindings, Helm chart and serialized configuration are unchanged. The release notes will carry the note for anyone building on the crate directly.Test Plan
make check-versions TAG=v1.10.1 VERSION_OVERRIDE=1.11.0reports every crate bumped and no remaining issues.cargo update -w --offlineproduced the 13Cargo.lockversion updates in this PR;cargo metadata --offlineresolves.smg-grpc-proto0.4.21 on PyPI inspected:vllm_engine_pb2.pyhasmm_processor_sourceand nomedia_identity.Checklist
cargo +nightly fmtpasses (no Rust source changed)cargo clippy --all-targets --all-features -- -D warningspasses (CI)