Skip to content

ci(trtllm): bump CI wheel to TensorRT-LLM 1.3.0rc18 - #1663

Merged
slin1237 merged 1 commit into
mainfrom
ci/trtllm-1.3.0rc18
Jun 11, 2026
Merged

slin1237 merged 1 commit into
mainfrom
ci/trtllm-1.3.0rc18

Conversation

@slin1237

@slin1237 slin1237 commented Jun 11, 2026 •

Copy link
Copy Markdown
Member

Description

CI-only bump of the TensorRT-LLM e2e wheel from 1.3.0rc14 to 1.3.0rc18. The Docker release pipelines (release-trtllm-docker.yml, nightly-engine-docker.yml) are untouched and keep their rc10 base images.

Changes (scripts/ci_install_trtllm.sh only)

  • TRTLLM_VERSION="1.3.0rc14" → "1.3.0rc18"
  • Header comment reworded so the rc14 feature provenance (gRPC serve from PR #11037, Harmony parser fixes #12045/#12467 for SMG test(e2e): enable Harmony tests on vLLM and TRT-LLM backends #801) reads correctly against the new pin.
  • NCCL_VERSION_CONSTRAINT deliberately unchanged: upstream requirements.txt at tag v1.3.0rc18 pins the identical nvidia-nccl-cu13>=2.28.9,<=2.29.2 (and the same torch>=2.10.0,<=2.11.0a0, cuda-python>=13).

Test Plan

  • bash -n scripts/ci_install_trtllm.sh — clean.
  • Verified tensorrt_llm-1.3.0rc18-cp312-cp312-manylinux_2_28_x86_64.whl is published on pypi.nvidia.com (public PyPI stops at rc15; the script already resolves via --pre --extra-index-url https://pypi.nvidia.com, so the pin is installable as-is).
  • Real gate: this PR's trtllm GPU e2e jobs.

Summary by CodeRabbit

  • Chores
    • Updated CI installation to use TensorRT-LLM pre-release version 1.3.0rc18, which includes gRPC serve and Harmony parser improvements.

cp312 manylinux_2_28 x86_64 wheels for 1.3.0rc18 are published on
pypi.nvidia.com (public PyPI stops at rc15; the script already installs
via the nvidia extra index with --pre). The NCCL constraint stays as-is:
upstream requirements.txt at v1.3.0rc18 pins the same
nvidia-nccl-cu13>=2.28.9,<=2.29.2.

CI-only: the Docker release pipelines (release-trtllm-docker.yml,
nightly-engine-docker.yml) keep their rc10 base images.

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ab407dd6-707d-4132-bc1a-d69f396d9cf6

📥 Commits

Reviewing files that changed from the base of the PR and between 06d761c and 9d1d81f.

📒 Files selected for processing (1)
  • scripts/ci_install_trtllm.sh

📝 Walkthrough

Walkthrough

The CI installation script is updated to pin TensorRT-LLM pre-release wheel version 1.3.0rc18 instead of 1.3.0rc14, with inline documentation revised to reflect gRPC serve and Harmony parser fixes included in the newer version.

Changes

TensorRT-LLM Version Upgrade

Layer / File(s) Summary
Upgrade TensorRT-LLM version to 1.3.0rc18
scripts/ci_install_trtllm.sh
Version constant bumped from 1.3.0rc14 to 1.3.0rc18 with inline documentation updated to describe included gRPC serve and Harmony parser fixes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • lightseekorg/smg#845: Related version pin update in workflow defaults for the same TensorRT-LLM dependency.
  • lightseekorg/smg#1501: Previous version pin update to scripts/ci_install_trtllm.sh with similar install logic and comment adjustments.

Suggested labels

ci

Suggested reviewers

  • gongwei-130
  • CatherineSue
  • key4ng
  • XinyueZhang369

Poem

🐰 A rabbit hops through CI scripts with glee,
One-point-four to one-point-eight, naturally!
The TensorRT wheels now spin more true,
With fixes for gRPC, both fresh and new. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: bumping the TensorRT-LLM wheel version from 1.3.0rc14 to 1.3.0rc18 in CI scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/trtllm-1.3.0rc18

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jun 11, 2026

Copy link
Copy Markdown

👋 The PR description doesn't fully follow PULL_REQUEST_TEMPLATE.md:

  • Missing header: ### Problem
  • Missing header: ### Solution

Please update the PR description so reviewers have the context they need.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward CI dependency pin bump (rc14 → rc18) with a matching comment update. No logic or config changes. LGTM.

@slin1237
slin1237 merged commit fe67243 into main Jun 11, 2026
37 of 38 checks passed
@slin1237
slin1237 deleted the ci/trtllm-1.3.0rc18 branch June 11, 2026 05:37
slin1237 added a commit that referenced this pull request Jun 11, 2026
Workspace crates, bindings, helm chart, and release workflows bumped
per make check-versions (smg 1.4.1 -> 1.5.0 plus per-crate minor/patch
bumps).

Also refresh the engine base images in the engine release and nightly
docker workflows to the versions CI now tests against:

- sglang: lmsysorg/sglang v0.5.10 -> v0.5.12.post1 (#1662)
- vllm:   vllm-openai matrix v0.19.0/v0.18.0/v0.17.0 ->
          v0.22.1/v0.21.0/v0.20.0 (#1625)
- trtllm: NGC release matrix 1.3.0rc10/rc9/rc8 -> rc18/rc17/rc16 (#1663)

All base image tags verified published (Docker Hub / nvcr.io).

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
slin1237 added a commit that referenced this pull request Jun 11, 2026
Workspace crates, bindings, helm chart, and release workflows bumped
per make check-versions (smg 1.4.1 -> 1.5.0 plus per-crate minor/patch
bumps).

Also refresh the engine base images in the engine release and nightly
docker workflows to the versions CI now tests against:

- sglang: lmsysorg/sglang v0.5.10 -> v0.5.12.post1 (#1662)
- vllm:   vllm-openai matrix v0.19.0/v0.18.0/v0.17.0 ->
          v0.22.1/v0.21.0/v0.20.0 (#1625)
- trtllm: NGC release matrix 1.3.0rc10/rc9/rc8 -> rc18/rc17/rc16 (#1663)

All base image tags verified published (Docker Hub / nvcr.io).

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant