Repository navigation
chore: bump versions for v1.6.0 release - #1792
Conversation
github-actions
Bot
added
tokenizer
📝 WalkthroughWalkthroughThis PR performs a coordinated v1.6.0 release bump: version fields are incremented across all Rust crate Changesv1.6.0 Release Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
👋 The PR description doesn't fully follow PULL_REQUEST_TEMPLATE.md:
Please update the PR description so reviewers have the context they need. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the version numbers across various workspace crates, language bindings (Go and Python), and the Helm chart deployment configuration, bumping the main project version from 1.5.0 to 1.6.0. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean version-bump PR (v1.5.0 → v1.6.0). All 23 files are mechanical version string updates across Cargo.toml, pyproject.toml, Helm chart, and CI workflows. Cross-checked workspace dependency versions against individual crate versions — all consistent, no mismatches.
0 issues found (0 🔴 Important · 0 🟡 Nit · 0 🟣 Pre-existing)
Minor note: PR description is missing the ### Problem / ### Solution headers from the template (commented on the PR).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efeeff37b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [project] | ||
| name = "smg" | ||
| version = "1.5.0" | ||
| version = "1.6.0" |
There was a problem hiding this comment.
When 1.6.0 wheels are built from this metadata, import smg; smg.__version__ still returns the hard-coded value from bindings/python/src/smg/version.py (exported by bindings/python/src/smg/__init__.py), which remains 1.1.0. Any client or diagnostic relying on the runtime version will see the wrong version for the 1.6.0 release, so the Python source version should be bumped with this metadata change.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
efeeff3 to
e00616a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e00616a064
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| engine_commit: ${{ inputs.sglang_commit || 'latest' }} | ||
| smg_repo: ${{ inputs.smg_repo || 'https://github.com/lightseekorg/smg' }} | ||
| smg_commit: ${{ github.event_name == 'pull_request' && 'main' || inputs.smg_commit || 'v1.5.0' }} | ||
| smg_commit: ${{ github.event_name == 'pull_request' && 'main' || inputs.smg_commit || 'v1.6.0' }} |
There was a problem hiding this comment.
For the push path, this workflow runs automatically on main when bindings/python/pyproject.toml changes, but there are no workflow_dispatch inputs, so this falls back to v1.6.0; _build-engine-image.yml then passes that into docker/engine.Dockerfile, which clones SMG and runs git checkout "$SMG_COMMIT". The documented release flow tags only after the release PR is merged (docs/contributing/development.md), so the automatic post-merge Docker release will try to check out a tag that does not exist yet and fail; the same fallback is present in the vLLM/TRTLLM release workflows. Use the push SHA/branch for push events, or trigger these builds only after the tag exists.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bindings/python/pyproject.toml`:
- Line 7: The version in pyproject.toml has been bumped to 1.6.0, but the
hardcoded __version__ variable in bindings/python/src/smg/version.py is still
set to 1.1.0. Since bindings/python/src/smg/__init__.py re-exports __version__
from smg.version, external consumers will see the old version at runtime. Update
the __version__ string in bindings/python/src/smg/version.py to match the
version defined in pyproject.toml, changing it from 1.1.0 to 1.6.0.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2b626f16-0891-4323-a6b9-e130a3f259ff
📒 Files selected for processing (23)
.github/workflows/release-sglang-docker.yml.github/workflows/release-trtllm-docker.yml.github/workflows/release-vllm-docker.ymlCargo.tomlbindings/golang/Cargo.tomlbindings/python/Cargo.tomlbindings/python/pyproject.tomlcrates/auth/Cargo.tomlcrates/data_connector/Cargo.tomlcrates/grpc_client/Cargo.tomlcrates/grpc_client/python/pyproject.tomlcrates/kv_index/Cargo.tomlcrates/mcp/Cargo.tomlcrates/mesh/Cargo.tomlcrates/multimodal/Cargo.tomlcrates/protocols/Cargo.tomlcrates/reasoning_parser/Cargo.tomlcrates/tokenizer/Cargo.tomlcrates/tool_parser/Cargo.tomlcrates/wasm/Cargo.tomlcrates/workflow/Cargo.tomldeploy/helm/smg/Chart.yamlmodel_gateway/Cargo.toml
| [project] | ||
| name = "smg" | ||
| version = "1.5.0" | ||
| version = "1.6.0" |
There was a problem hiding this comment.
Version mismatch between pyproject.toml and hardcoded smg/version.py.
The pyproject.toml is bumped to 1.6.0, but the module-level __version__ in bindings/python/src/smg/version.py remains hardcoded at "1.1.0". Since bindings/python/src/smg/__init__.py re-exports __version__ from smg.version, external consumers will observe version 1.1.0 at runtime, not 1.6.0. This creates a package version mismatch that could confuse users and break version-pinning logic.
Ensure that bindings/python/src/smg/version.py is updated to __version__ = "1.6.0" to match the pyproject.toml bump.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bindings/python/pyproject.toml` at line 7, The version in pyproject.toml has
been bumped to 1.6.0, but the hardcoded __version__ variable in
bindings/python/src/smg/version.py is still set to 1.1.0. Since
bindings/python/src/smg/__init__.py re-exports __version__ from smg.version,
external consumers will see the old version at runtime. Update the __version__
string in bindings/python/src/smg/version.py to match the version defined in
pyproject.toml, changing it from 1.1.0 to 1.6.0.
2 participants
Description
Version bumps for the SMG v1.6.0 release, generated by
make check-versionsagainst tagv1.5.0. This is a version-bump-only release — no engine base-image changes (therelease-{sglang,vllm,trtllm}-docker.ymldiffs are limited to the SMG version refsv1.5.0 → v1.6.0, not engine image updates).Changes
Workspace versions (per
check-versionsproposed fixes, all applied):smg1.5.0 → 1.6.0; synced:smg-python,smg-golang, pythonpyproject.toml, helm chart, and the SMG refs inrelease-{sglang,vllm,trtllm}-docker.ymlllm-multimodal1.7.0,smg-grpc-client1.7.0openai-protocol1.8.1,reasoning-parser1.3.1,tool-parser1.3.1,wfaas1.0.5,llm-tokenizer1.4.1,smg-auth1.2.1,smg-mcp2.3.1,kv-index1.3.1,data-connector2.3.1,smg-wasm1.1.2,smg-mesh1.4.1,smg-grpc-proto0.4.11smg-grpc-servicerwas already atv0.5.6— no change needed.Test Plan
make check-versionsre-run after applying: "All versions consistent." (14 crates + 2 Python packages reconciled, 0 issues)release-*-docker.ymldiffs are limited to thev1.5.0 → v1.6.0SMG version refs.Cargo.lockis gitignored in this repo (same as prior release PRs chore: bump versions for v1.5.0 release #1665 / chore: bump versions for v1.4.1 release #1080); workspace lock refresh happens at build time.Summary by CodeRabbit