Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded requirements.txt versions #624

Closed
wants to merge 12 commits into from
Closed

upgraded requirements.txt versions #624

wants to merge 12 commits into from

Conversation

rahulkumaran
Copy link
Contributor

Fixes #623

Checklist

  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added necessary documentation about the functionality in the appropriate .md file

Short description of what this PR does:

  • This PR upgrades the versions in requirements.txt
  • The latest stable versions now exists there.

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 3, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 3, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f132e5b...8188159. Read the comment docs.

@rahulkumaran
Copy link
Contributor Author

@thinkingserious could you please review this? Thanks! 😄

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy labels Oct 4, 2018
@thinkingserious
Copy link
Contributor

Hello @rahulkumaran,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: ready for deploy code ready to be released in next deploy status: code review request requesting a community code review or review from Twilio labels Oct 4, 2018
@thinkingserious
Copy link
Contributor

@rahulkumaran,

Could you please merge this into this branch instead? Thanks!

The python-http-client upgrade is a breaking change.

With Best Regards,

Elmer

@rahulkumaran rahulkumaran changed the base branch from master to v4 October 4, 2018 04:19
@rahulkumaran rahulkumaran changed the base branch from v4 to master October 4, 2018 04:24
@rahulkumaran
Copy link
Contributor Author

@thinkingserious , sure! Will do that! There are a lot of conflicts arising currently when i try merging it into branch v4, so I'll send another PR for the same. Thanks!

@rahulkumaran rahulkumaran mentioned this pull request Oct 4, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade versions of requirements in requirements.txt
3 participants