Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #457, refactor sengrid get method of Mail class #486

Closed
wants to merge 2 commits into from

Conversation

Prashant-Surya
Copy link

Refactored Mail class in sendgrid/helpers/mail which would fix get method complexity.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 29, 2017

Codecov Report

Merging #486 into master will decrease coverage by 5.15%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   87.91%   82.76%   -5.16%     
==========================================
  Files          30       30              
  Lines         935     1021      +86     
  Branches      115      158      +43     
==========================================
+ Hits          822      845      +23     
- Misses         55       86      +31     
- Partials       58       90      +32
Impacted Files Coverage Δ
sendgrid/helpers/mail/mail.py 96.2% <84.61%> (+1.43%) ⬆️
sendgrid/helpers/inbound/send.py 0% <0%> (-93.75%) ⬇️
sendgrid/helpers/mail/category.py 81.81% <0%> (-18.19%) ⬇️
sendgrid/helpers/mail/asm.py 73.91% <0%> (-10.09%) ⬇️
sendgrid/helpers/mail/section.py 85.71% <0%> (-8.41%) ⬇️
sendgrid/helpers/mail/header.py 85.71% <0%> (-8.41%) ⬇️
sendgrid/helpers/mail/substitution.py 85.71% <0%> (-8.41%) ⬇️
sendgrid/helpers/mail/custom_arg.py 85.71% <0%> (-8.41%) ⬇️
sendgrid/helpers/mail/ganalytics.py 79.66% <0%> (-7.58%) ⬇️
sendgrid/helpers/mail/subscription_tracking.py 80.48% <0%> (-7.4%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f86b7...a9173f2. Read the comment docs.

@thinkingserious
Copy link
Contributor

@Prashant-Surya

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@Prashant-Surya
Copy link
Author

@thinkingserious Thank you :) I will contribute more to sendgrid repos.

@thinkingserious
Copy link
Contributor

That’s awesome @Prashant-Surya, thank you!

@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Feb 27, 2018
thinkingserious added a commit that referenced this pull request Jul 12, 2018
@thinkingserious
Copy link
Contributor

Thanks again for helping improve this SDK!

We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants