-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix issues in sendgrid/helpers/mail/mail.py #496
Conversation
…ilar blocks of code; revert private variables to be public if they do not need mutations during setting/getting
…ilar blocks of code; revert private variables to be public if they do not need mutations during setting/getting
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
- Coverage 83% 81.83% -1.18%
==========================================
Files 30 30
Lines 1024 936 -88
Branches 160 133 -27
==========================================
- Hits 850 766 -84
Misses 84 84
+ Partials 90 86 -4
Continue to review full report at Codecov.
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
Thanks again for helping improve this SDK! We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress. With Best Regards, Elmer |
Fixes
Fixes #457
Fixes #458
Checklist
Short description of what this PR does: