Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #630

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

rahulkumaran
Copy link
Contributor

Fixes #623

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.

Short description of what this PR does:

  • Currently, the versions in requirements.txt are not up to date
  • This PR upgrades the versions of the python modules to the latest versions

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@rahulkumaran
Copy link
Contributor Author

@thinkingserious this is a PR that's the same as #624 . Had to close the previous one because a lot of conflicts were arising. Anyway, this is good to go now! 😄
Thanks!

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #630 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #630   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files          37       37           
  Lines         952      952           
  Branches      105      105           
=======================================
  Hits          803      803           
  Misses         92       92           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a0ad0...e4f1097. Read the comment docs.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap and removed status: ready for deploy code ready to be released in next deploy labels Oct 6, 2018
@thinkingserious thinkingserious merged commit 33a3576 into sendgrid:v4 Oct 6, 2018
@thinkingserious
Copy link
Contributor

Hello @rahulkumaran,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @rahulkumaran,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants