-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor personalization.py as in issue #501 #493
Conversation
reduce Cognitive Complexity of get method and refactor init and other methods of personalization class
also replacing `"` with "`"
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 87.91% 87.83% -0.08%
==========================================
Files 30 30
Lines 935 929 -6
Branches 115 113 -2
==========================================
- Hits 822 816 -6
Misses 55 55
Partials 58 58
Continue to review full report at Codecov.
|
@thinkingserious @mbernier hey, this PR is open for around a day. Can we do code review and merge the changes. Being my first open source contribution to a popular repo used by many, I am a bit excited to see it merged. |
@thinkingserious @mbernier do you guys really want people to contribute to your repo? I have this Pr for two days and have pinged multiple times on issue and PR to code review or merge and I see no reply but other PRs are being merged and here I am back merging and resolving conflicts. Don't you guys have the courtesy to reply at least? People like you and these shitty repos demotivate open source contributors. Don't be an ass! Do hell with your hacktoberfest. |
@thinkingserious please at least close the repo if not needed! |
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
@mbernier Hey, thanks and sorry for being rude! I was overexcited to see my first contribution to a well known and used repo merged. Leaving aside t-shirt, I would like to get this merged. Please do a code review whenever free and suggest changes. Travis is falling after back-merge, due to some issue in master. I will try fixing that also. Thanks for the response. |
No worries @Codervikash! We appreciate your excitement and hope that you keep an eye on our repos going forward! |
Thanks again for helping improve this SDK! We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress. With Best Regards, Elmer |
reduce Cognitive Complexity of get method and refactor init and other methods of personalization class
Fixes #501
Checklist
Short description of what this PR does:
get
methodIf you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.