Skip to content

add regression test for packus_epi16 issue - #162341

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:stdarch-regression-test
Sep 7, 2026
Merged

add regression test for packus_epi16 issue#162341
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:stdarch-regression-test

Conversation

@RalfJung

@RalfJung RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member

View all comments

#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 5, 2026
@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@RalfJung

RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=test-x86_64*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
add regression test for packus_epi16 issue


try-job: test-x86_64*
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2026
@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 769811c failed: CI. Failed job:

@RalfJung

RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
add regression test for packus_epi16 issue


try-job: x86_64*
@rust-bors

rust-bors Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7d48998 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@RalfJung

RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-gnu*

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
add regression test for packus_epi16 issue


try-job: x86_64-gnu*
@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 078a914 (078a914ddaaed3f5698383b5200f38b5a14a719f)
Base parent: f207aa3 (f207aa3913114c3326bc0b88acbd12b10244edf8)

@folkertdev folkertdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit aab2b85 has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 6, 2026
…r=folkertdev

add regression test for packus_epi16 issue

rust-lang#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159541 (Use query for Variant InhabitedPredicate)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
 - #162341 (add regression test for packus_epi16 issue)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 6, 2026
…r=folkertdev

add regression test for packus_epi16 issue

rust-lang#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev
@RalfJung
RalfJung force-pushed the stdarch-regression-test branch from aab2b85 to dda8b5e Compare September 6, 2026 18:43
@JonathanBrouwer

Copy link
Copy Markdown
Member

FYI you can override this by passing nolimit as an argument, the error should probably say that...
I'll make a fix

@RalfJung

RalfJung commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64* nolimit

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
add regression test for packus_epi16 issue


try-job: x86_64*
try-nolimit
@RalfJung

RalfJung commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

FYI you can override this by passing nolimit as an argument, the error should probably say that... I'll make a fix

Yeah I know that, but the docs also said one should only use it when really needed so I didn't dare using it.^^

@JonathanBrouwer

Copy link
Copy Markdown
Member

Afaik it's mostly a guard against accidental invocations, where do the docs say that?

@RalfJung

RalfJung commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

I forgot, I thought I read it somewhere... maybe it was Zulip? #t-infra/announcements > Bors changelog @ 💬

This is designed for rare situations for complex PRs where you want to essentially test everything before landing it (e.g. LLVM updates or complex feature stabilizations). Please use it sparingly.

@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 4b30e5c failed: CI. Failed jobs:

@RalfJung
RalfJung force-pushed the stdarch-regression-test branch from dda8b5e to 14989dc Compare September 6, 2026 21:54
@RalfJung

RalfJung commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

@folkertdev I think we have to just restrict the test to Linux... does that seem reasonable?

@folkertdev

Copy link
Copy Markdown
Contributor

Yes, that's fine

@RalfJung

RalfJung commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@bors r=folkertdev

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 14989dc has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 7, 2026
…r=folkertdev

add regression test for packus_epi16 issue

rust-lang#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev
jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 7, 2026
…r=folkertdev

add regression test for packus_epi16 issue

rust-lang#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 7, 2026
…r=folkertdev

add regression test for packus_epi16 issue

rust-lang#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup of 14 pull requests

Successful merges:

 - #162404 (`rust-analyzer` subtree update)
 - #161624 (diagnostics: Point closure trait errors at captured values)
 - #161697 (make `Complex` ABI-compatible on sparc64 and powerpc64)
 - #162182 (delay unexpected successful goal during ambiguity reporting)
 - #162328 (Allow overriding filecheck even if LLVM is built or downloaded)
 - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`)
 - #162381 (fix bare urls split text)
 - #162388 (std: fix set_permissions_nofollow on espidf and horizon)
 - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support)
 - #162341 (add regression test for packus_epi16 issue)
 - #162383 (Add a hint for using `nolimit` to the limiting error message)
 - #162384 (remove EnumSizeOpt)
 - #162390 (remove outdated comment in `UnsafeCell::raw_get` source)
 - #162397 (docs: Ask for ABI documentation in the platform support template)
@rust-bors
rust-bors Bot merged commit d8d5fa2 into rust-lang:main Sep 7, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup merge of #162341 - RalfJung:stdarch-regression-test, r=folkertdev

add regression test for packus_epi16 issue

#159464 got fixed without a test. This adds the missing test.

Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all.

Cc @folkertdev
@RalfJung
RalfJung deleted the stdarch-regression-test branch September 7, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants