Allow overriding filecheck even if LLVM is built or downloaded - #162328
Merged
Conversation
Collaborator
|
This PR modifies If appropriate, please update This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jieyouxu
approved these changes
Sep 5, 2026
Contributor
|
Thanks, this seems to fix the issue. One thing that would be nice if you could find out how to fix this: the llvm sub-module still seems to be cloned on a gcc-only config. |
Member
Author
|
There are surprisingly many things in bootstrap that want to build LLVM 😆 |
Contributor
|
Thanks. This seems to fix all my issues. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Hmm, it won't be so easy. Sorry, I will revert the last commit, meaning that LLVM will still be checked out. I need to do more refactorings in bootstrap to feel confident that this change won't break anything (which it just did). |
Kobzol
force-pushed
the
bootstrap-filecheck-relax
branch
from
September 7, 2026 06:24
0a387fc to
a490ea6
Compare
Member
Author
|
@bors r=jieyouxu Approving what you previously approved, with the lint addressed. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 7, 2026
…r=jieyouxu Allow overriding filecheck even if LLVM is built or downloaded @antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap. r? jieyouxu
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 7, 2026
…r=jieyouxu Allow overriding filecheck even if LLVM is built or downloaded @antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap. r? jieyouxu
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 7, 2026
…r=jieyouxu Allow overriding filecheck even if LLVM is built or downloaded @antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap. r? jieyouxu
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 7, 2026
…r=jieyouxu Allow overriding filecheck even if LLVM is built or downloaded @antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap. r? jieyouxu
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Rollup of 14 pull requests Successful merges: - #162404 (`rust-analyzer` subtree update) - #161624 (diagnostics: Point closure trait errors at captured values) - #161697 (make `Complex` ABI-compatible on sparc64 and powerpc64) - #162182 (delay unexpected successful goal during ambiguity reporting) - #162328 (Allow overriding filecheck even if LLVM is built or downloaded) - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`) - #162381 (fix bare urls split text) - #162388 (std: fix set_permissions_nofollow on espidf and horizon) - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support) - #162341 (add regression test for packus_epi16 issue) - #162383 (Add a hint for using `nolimit` to the limiting error message) - #162384 (remove EnumSizeOpt) - #162390 (remove outdated comment in `UnsafeCell::raw_get` source) - #162397 (docs: Ask for ABI documentation in the platform support template)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Rollup merge of #162328 - Kobzol:bootstrap-filecheck-relax, r=jieyouxu Allow overriding filecheck even if LLVM is built or downloaded @antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap. r? jieyouxu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap.
r? jieyouxu