Rollup of 5 pull requests - #162370
Closed
JonathanBrouwer wants to merge 10 commits into
Closed
Conversation
…, r=Nadrieril Use query for Variant InhabitedPredicate It looks like there may be some benefit from caching.
Use `#[repr(C)]` on debuginfo test structs This fixes a couple of issues. * LLDB reading PDB debug info re-orders fields and displays them in offset order instead of source-order like DWARF. While this has been [fixed upstream](llvm/llvm-project#218731), it'll be quite a while before it's reflected in CI runners and such * For all targets, the structs were often written (and named) under the assumption that they would have specific layouts. Nothing was actually enforcing those assumed layouts, so very often a type would be named e.g. `HasInternalPadding` but rust would reorder it such that no internal padding existed. `struct-with-destructor.rs` is still iffy. I'll test it when I get home and can update my main PC's LLDB. On my remote PC (lldb 22.1.2) it didn't fix the test, and it looked like the variable was straight up being read incorrectly: ``` // expected: (struct_with_destructor::NestedOuter) nested = {a:{a:{x:7890, y:9870}}} // got: (struct_with_destructor::NestedOuter) nested = {a:{a:{y:1378684509906, x:9870}} ``` On my laptop when manually inspecting it (CodeLLDB which uses 22.1.8 under the hood) everything looked fine, so it might have been a bug that LLDB patched. Part of the MSVC test fixes for rust-lang#161657 r? @Kobzol, @jieyouxu --- test-jobs: aarch64-apple-1 test-jobs: aarch64-msvc-1 test-jobs: x86_64-msvc-1 test-jobs: x86_64-mingw-1
…nyukang remove stale/duplicate tests Conversation from: https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Duplicate.20tests/with/621165039 * `recursion2.rs` -> `recursion1.rs` * `drop-track-field-assign-nonsend.rs` -> `field-assign-nonsend.rs` * `drop-track-field-assign.rs` -> `field-assign.rs` * `suggest-local-var-for-vector.rs` -> `suggest-storing-local-var-for-vector.rs` * `recursion-issue-105275.rs` -> `recursion-issue-105937.rs` * `migrate-fail.rs` -> `nll-fail.rs` * `migrate-pass.rs` -> `nll-pass.rs` * `issue-29914-2.rs` -> `issue-29914.rs` * `drop-tracking-parent-expression.rs` -> `parent-expression.rs` * `tuple-like-structs-cross-crate-7899.rs` -> `tuple-struct-cross-crate-7899.rs` * `E0508-fail.rs` -> `E0508.rs` * `ex3-both-anon-regions-one-is-struct-4.rs` -> `ex3-both-anon-regions-one-is-struct-3.rs` * `stability_cfg2.rs` -> `stability-cfg2.rs` * `issue-1802-2.rs` -> `issue-1802-1.rs` * `tool_lints_2018_preview.rs` -> `tool_lints-rpass.rs` * `issue-58951-2.rs` -> `issue-58951.rs` * `issue-74761-2.rs` -> `issue-74761.rs` * `issue-30276-feature-flagged.rs` -> `issue-30276.rs`
Add several new LLDB feature flags These flags aren't currently used anywhere, but the features they describe are *incredibly* useful (particularly for a wide pointer visualizer that I have in the works). This patch serves both to document them (especially a feature we *shouldn't* use), and to prep for future visualizers.
…r=folkertdev add regression test for packus_epi16 issue rust-lang#159464 got fixed without a test. This adds the missing test. Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all. Cc @folkertdev
rustbot
added
A-tidy
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
…uwer Rollup of 5 pull requests Successful merges: - #159541 (Use query for Variant InhabitedPredicate) - #162364 (Use `#[repr(C)]` on debuginfo test structs) - #162215 (remove stale/duplicate tests) - #162335 (Add several new LLDB feature flags) - #162341 (add regression test for packus_epi16 issue)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 54435ae failed: CI. Failed job:
|
Member
Author
|
@bors retry |
rust-bors
Bot
added
S-waiting-on-bors
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
Contributor
|
💔 Test for 42e3705 failed: CI. Failed jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[repr(C)]on debuginfo test structs #162364 (Use#[repr(C)]on debuginfo test structs)r? @ghost
Create a similar rollup