Skip to content

Add several new LLDB feature flags - #162335

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:flags
Sep 6, 2026
Merged

Add several new LLDB feature flags#162335
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:flags

Conversation

@Walnut356

@Walnut356 Walnut356 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

These flags aren't currently used anywhere, but the features they describe are incredibly useful (particularly for a wide pointer visualizer that I have in the works). This patch serves both to document them (especially a feature we shouldn't use), and to prep for future visualizers.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2026
@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Mark-Simulacrum

@Walnut356 Walnut356 changed the title Add several new LLDB flags Add several new LLDB feature flags Sep 5, 2026
Comment thread src/etc/lldb_providers.py

@Nikolay-Sitnikov Nikolay-Sitnikov Sep 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you also add logic to detect_features() in order to make these features usable in future visualizers?

View changes since the review

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
r? me @bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit db6c4b2 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 6, 2026
Add several new LLDB feature flags

These flags aren't currently used anywhere, but the features they describe are *incredibly* useful (particularly for a wide pointer visualizer that I have in the works). This patch serves both to document them (especially a feature we *shouldn't* use), and to prep for future visualizers.
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159541 (Use query for Variant InhabitedPredicate)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
 - #162341 (add regression test for packus_epi16 issue)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 6, 2026
Add several new LLDB feature flags

These flags aren't currently used anywhere, but the features they describe are *incredibly* useful (particularly for a wide pointer visualizer that I have in the works). This patch serves both to document them (especially a feature we *shouldn't* use), and to prep for future visualizers.
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #162358 (Force u8/i8 numeric formatting on LLDB)
 - #162359 (Use `lldb.eTypeOptionHideChildren` for msvc tuples)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
 - #162341 (add regression test for packus_epi16 issue)
 - #162374 (Make `VaArgSafe` dyn-incompatible)
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors try jobs=x86_64-mingw-1,x86_64-msvc-1

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
Add several new LLDB feature flags


try-job: x86_64-mingw-1
try-job: x86_64-msvc-1
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #162358 (Force u8/i8 numeric formatting on LLDB)
 - #162359 (Use `lldb.eTypeOptionHideChildren` for msvc tuples)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: f8259ce (f8259ce5a10d3b3f97bfb93778b4bdbd59ad72b2)
Base parent: da47efd (da47efd27287edb02eed0b5a178a165c8f258e37)

@rust-bors
rust-bors Bot merged commit f5d6bdc into rust-lang:main Sep 6, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 6, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
Rollup merge of #162335 - Walnut356:flags, r=jieyouxu

Add several new LLDB feature flags

These flags aren't currently used anywhere, but the features they describe are *incredibly* useful (particularly for a wide pointer visualizer that I have in the works). This patch serves both to document them (especially a feature we *shouldn't* use), and to prep for future visualizers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants