Skip to content

docs(core): correct ARMv8-M Baseline atomic CAS support - #162319

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bardiharborow:docs/fix-thumbv8m-atomic-cas
Sep 7, 2026
Merged

docs(core): correct ARMv8-M Baseline atomic CAS support#162319
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bardiharborow:docs/fix-thumbv8m-atomic-cas

Conversation

@bardiharborow

@bardiharborow bardiharborow commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only.

The incorrect ARMv8-M Baseline comment was introduced in #149241 while updating the atomic portability notes for ARMv4T/ARMv5TE.

Limit that restriction to ARMv6-M and include thumbv8m.base-* among the targets with full CAS support.

@rustbot label +A-docs +A-atomic +O-Arm +T-libs

ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only.

 Limit that restriction to ARMv6-M and include thumbv8m.base-* among the targets with full CAS support.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 5, 2026
@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from Darksonn, JohnTitor, Mark-Simulacrum, clarfonthey

@rustbot rustbot added A-atomic Area: Atomics, barriers, and sync primitives A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels Sep 5, 2026

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit a9fd5e0 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 7, 2026
…omic-cas, r=JohnTitor

docs(core): correct ARMv8-M Baseline atomic CAS support

ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only.

The incorrect ARMv8-M Baseline comment was introduced in rust-lang#149241 while updating the atomic portability notes for ARMv4T/ARMv5TE.

Limit that restriction to ARMv6-M and include `thumbv8m.base-*` among the targets with full CAS support.

@rustbot label +A-docs +A-atomic +O-Arm +T-libs
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup of 4 pull requests

Successful merges:

 - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`)
 - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support)
 - #162383 (Add a hint for using `nolimit` to the limiting error message)
 - #162384 (remove EnumSizeOpt)
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup of 14 pull requests

Successful merges:

 - #162404 (`rust-analyzer` subtree update)
 - #161624 (diagnostics: Point closure trait errors at captured values)
 - #161697 (make `Complex` ABI-compatible on sparc64 and powerpc64)
 - #162182 (delay unexpected successful goal during ambiguity reporting)
 - #162328 (Allow overriding filecheck even if LLVM is built or downloaded)
 - #162367 (Use `reason` for tracked item diagnostics from `cfg_select!`)
 - #162381 (fix bare urls split text)
 - #162388 (std: fix set_permissions_nofollow on espidf and horizon)
 - #162319 (docs(core): correct ARMv8-M Baseline atomic CAS support)
 - #162341 (add regression test for packus_epi16 issue)
 - #162383 (Add a hint for using `nolimit` to the limiting error message)
 - #162384 (remove EnumSizeOpt)
 - #162390 (remove outdated comment in `UnsafeCell::raw_get` source)
 - #162397 (docs: Ask for ABI documentation in the platform support template)
@rust-bors
rust-bors Bot merged commit 4e8672f into rust-lang:main Sep 7, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup merge of #162319 - bardiharborow:docs/fix-thumbv8m-atomic-cas, r=JohnTitor

docs(core): correct ARMv8-M Baseline atomic CAS support

ARMv8-M Baseline targets support CAS operations, but the atomic module docs incorrectly list them as load and store-only.

The incorrect ARMv8-M Baseline comment was introduced in #149241 while updating the atomic portability notes for ARMv4T/ARMv5TE.

Limit that restriction to ARMv6-M and include `thumbv8m.base-*` among the targets with full CAS support.

@rustbot label +A-docs +A-atomic +O-Arm +T-libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-atomic Area: Atomics, barriers, and sync primitives A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants