Rollup of 5 pull requests - #162403
Closed
jhpratt wants to merge 11 commits into
Closed
Conversation
read(true) was chained onto custom_flags(O_NOFOLLOW) inside a cfg block that excludes those two targets, so their OpenOptions had no access mode set and open() returned EINVAL before any chmod happened. Neither target has an fchmodat arm either, so set_permissions_nofollow could never succeed there.
…r=jieyouxu Allow overriding filecheck even if LLVM is built or downloaded @antoyo ran into some issues with this, because he wants to run UI tests using the GCC codegen backend. But the tests still require LLVM FileCheck for checking annotations, so he had to download/build LLVM. But really the thing he wants is just to provide an external FileCheck, and that's it. I don't see why we couldn't allow providing filecheck separately, now that it is an explicit step in bootstrap. r? jieyouxu
… r=notriddle fix bare urls split text Fixes rust-lang#162345. The whole fix is explained in the comment in the diff.
…x, r=Darksonn std: fix set_permissions_nofollow on espidf and horizon read(true) was chained onto custom_flags(O_NOFOLLOW) inside a cfg block that excludes those two targets, so their OpenOptions had no access mode set and open() returned EINVAL before any chmod happened. Neither target has an fchmodat arm either, so set_permissions_nofollow could never succeed there.
…r=folkertdev add regression test for packus_epi16 issue rust-lang#159464 got fixed without a test. This adds the missing test. Ideally this would be tested in stdarch, but we don't have enough infrastructure for that. Testing it here is better than not testing it at all. Cc @folkertdev
…=RalfJung remove outdated comment in `UnsafeCell::raw_get` source It was decided that UnsafeCell can be accessed mutably without going through `get` (rust-lang/unsafe-code-guidelines#281) and a comment stating that std has special privileges was removed in rust-lang#159730, but that PR missed `raw_get`. This comment actively contradicted `CovariantUnsafeCell`: https://github.com/rust-lang/rust/blob/5a2be9f5f075d31e3ca5526b5b029881ce441253/library/core/src/cell/covariant_unsafe_cell.rs#L154-L161
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
Closing to add a p=1 pr |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
UnsafeCell::raw_getsource #162390 (remove outdated comment inUnsafeCell::raw_getsource)r? @ghost
Create a similar rollup