Introduce #[diagnostic::on_move] on `Arc`#154669

Open

rperier wants to merge 1 commit intorust-lang:mainfrom

rperier:diagnostic_on_move_for_the_arc_type

Contributor

rperier commented Apr 1, 2026 •

edited by rustbot

Loading

This is related to the tracking issue #154181 and to the original issue #149862 .

rustbot assigned TaKO8Ki

rustbot added S-waiting-on-review T-compiler T-libs labels

Collaborator

rustbot commented Apr 1, 2026

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 13 candidates

Contributor Author

rperier commented Apr 1, 2026

tgross35 approved these changes

View reviewed changes

Contributor

tgross35 left a comment •

edited by rustbot

Loading

One nit, r=me either way

View changes since this review

library/alloc/src/sync.rs Outdated Show resolved Hide resolved

tgross35 assigned tgross35 and unassigned TaKO8Ki


          Introduce #[diagnostic::on_move] on Arc

12f8364

This annotates the `Arc` type with the diagnostic attribute
`#[diagnostic::on_move]`. Now when a moved `Arc` is borrowed,
a suggestion to clone it is made, with a label explaining why.

rperier force-pushed the diagnostic_on_move_for_the_arc_type branch from d4ccfcc to 12f8364 Compare

April 1, 2026 09:01

Collaborator

rustbot commented Apr 1, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Contributor Author

rperier commented Apr 1, 2026

Rebased onto main and fixed the label message

This was referenced Apr 1, 2026

Tracking Issue for #[diagnostic::on_move] #154181

Open

Introduce #[diagnostic::on_move] on Rc #154678

Open

Contributor

tgross35 commented Apr 1, 2026

Contributor

rust-bors bot commented Apr 1, 2026

📌 Commit 12f8364 has been approved by tgross35

It is now in the queue for this repository.

rust-bors bot added S-waiting-on-bors and removed S-waiting-on-review labels

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#154669 - rperier:diagnostic_on_move_for_the…

800f338

…_arc_type, r=tgross35

Introduce #[diagnostic::on_move] on `Arc`

This is related to the tracking issue rust-lang#154181 and to the original issue rust-lang#149862 .

GuillaumeGomez mentioned this pull request

Rollup of 7 pull requests #154693

Closed

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #154693 - GuillaumeGomez:rollup-4KpJ9MV, r=GuillaumeGomez

2f9fff2

Rollup of 7 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#154669 - rperier:diagnostic_on_move_for_the…

3beee02

…_arc_type, r=tgross35

Introduce #[diagnostic::on_move] on `Arc`

This is related to the tracking issue rust-lang#154181 and to the original issue rust-lang#149862 .

jhpratt mentioned this pull request

Rollup of 11 pull requests #154701

Closed

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #154701 - jhpratt:rollup-u0ZMiMs, r=jhpratt

21dbcd2

Rollup of 11 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153286 (various fixes for scalable vectors)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#154669 - rperier:diagnostic_on_move_for_the…

087b40f

…_arc_type, r=tgross35

Introduce #[diagnostic::on_move] on `Arc`

This is related to the tracking issue rust-lang#154181 and to the original issue rust-lang#149862 .

jhpratt mentioned this pull request

Rollup of 11 pull requests #154705

Closed

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #154705 - jhpratt:rollup-Ef0J2Wm, r=jhpratt

92a904d

Rollup of 11 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#154669 - rperier:diagnostic_on_move_for_the…

bf219da

…_arc_type, r=tgross35

Introduce #[diagnostic::on_move] on `Arc`

This is related to the tracking issue rust-lang#154181 and to the original issue rust-lang#149862 .

JonathanBrouwer mentioned this pull request

Rollup of 21 pull requests #154716

Closed

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #154716 - JonathanBrouwer:rollup-mjhodpw, r=JonathanBro…

fc16f98

…uwer

Rollup of 21 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153286 (various fixes for scalable vectors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #154713 (Stop compiling when we get resolving crate failure)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#154669 - rperier:diagnostic_on_move_for_the…

93c62ca

…_arc_type, r=tgross35

Introduce #[diagnostic::on_move] on `Arc`

This is related to the tracking issue rust-lang#154181 and to the original issue rust-lang#149862 .

JonathanBrouwer mentioned this pull request

Rollup of 21 pull requests #154718

Closed

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #154718 - JonathanBrouwer:rollup-52sF5zX, r=JonathanBro…

0e9b775

…uwer

Rollup of 21 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153286 (various fixes for scalable vectors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #153614 (`FindParamInClause` handle edge-cases)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#154669 - rperier:diagnostic_on_move_for_the…

ae9a4a4

…_arc_type, r=tgross35

Introduce #[diagnostic::on_move] on `Arc`

This is related to the tracking issue rust-lang#154181 and to the original issue rust-lang#149862 .

JonathanBrouwer mentioned this pull request

Rollup of 20 pull requests #154727

Open

rust-bors bot pushed a commit that referenced this pull request


          Auto merge of #154727 - JonathanBrouwer:rollup-I3Rg5V6, r=JonathanBro…

55e86c9

…uwer

Rollup of 20 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #153614 (`FindParamInClause` handle edge-cases)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-compiler T-libs