Rename `probe_ty_var` to `try_resolve_ty_var` by jdonszelmann · Pull Request #154578 · rust-lang/rust

jdonszelmann · 2026-03-30T11:19:20Z

r? @lcnr

rustbot · 2026-03-30T11:19:24Z

Some changes occurred in need_type_info.rs

cc @lcnr

changes to the core type system

cc @lcnr

lcnr · 2026-03-30T11:29:30Z

cc @BoxyUwU

@bors r+ rollup

rust-bors · 2026-03-30T11:29:33Z

📌 Commit 53ceea8 has been approved by lcnr

It is now in the queue for this repository.

BoxyUwU · 2026-03-30T11:49:53Z

@bors r-

why not also change the const equivalent?

jdonszelmann · 2026-03-30T12:51:59Z

because I didn't realize there was one, makes sense though hehe

jdonszelmann · 2026-03-30T12:52:08Z

@BoxyUwU pushed that

BoxyUwU

r=me,lcnr

View changes since this review

BoxyUwU · 2026-03-30T15:29:18Z

Actually lets wait for #154053 to land, it's already had to be rebased so many times and this will conflict 😅

BoxyUwU · 2026-03-31T10:51:27Z

#154053 has landed so this is good to go (maybe after a rebase, though it doesnt say anything about conflicts)

Co-authored-by: khyperia <953151+khyperia@users.noreply.github.com>

rustbot · 2026-04-02T09:24:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-04-02T10:16:51Z

@bors r=lcnr,boxyuwu

rust-bors · 2026-04-02T10:16:54Z

📌 Commit 28b06a6 has been approved by lcnr,boxyuwu

It is now in the queue for this repository.

@lcnr

…boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

@lcnr

…boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #154713 (Stop compiling when we get resolving crate failure) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

@lcnr

…boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…uwer Rollup of 20 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

@lcnr

Rollup merge of #154578 - jdonszelmann:rename-probe, r=lcnr,boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

…uwer Rollup of 20 pull requests Successful merges: - rust-lang/rust#153105 (Compute the result of a projection type with region errors) - rust-lang/rust#153532 (Attributes containing rustc) - rust-lang/rust#153960 (Make `layout_of` cycles fatal errors) - rust-lang/rust#154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - rust-lang/rust#154666 (Remove `StableHashContext` impls) - rust-lang/rust#154669 (Introduce #[diagnostic::on_move] on `Arc`) - rust-lang/rust#154710 (opaque_generic_const_args -> generic_const_args) - rust-lang/rust#154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - rust-lang/rust#153614 (`FindParamInClause` handle edge-cases) - rust-lang/rust#154213 (tidy-alphabetical: fix line number in error message) - rust-lang/rust#154425 (Migrate transmute tests) - rust-lang/rust#154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - rust-lang/rust#154469 (mGCA: Lower spans for literal const args) - rust-lang/rust#154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - rust-lang/rust#154615 (Moving issues) - rust-lang/rust#154644 (rustdoc: seperate methods and associated functions in sidebar) - rust-lang/rust#154660 (Avoid creating async return opaques for foreign async fns) - rust-lang/rust#154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - rust-lang/rust#154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - rust-lang/rust#154709 (Revert `Ty` type alias in `rustc_type_ir`)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned lcnr Mar 30, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2026

jdonszelmann force-pushed the rename-probe branch from 53ceea8 to 62c0c0e Compare March 30, 2026 12:51

This comment has been minimized.

Sign in to view

BoxyUwU approved these changes Mar 30, 2026

View reviewed changes

Rename probe_ty_var to try_resolve_ty_var

28b06a6

Co-authored-by: khyperia <953151+khyperia@users.noreply.github.com>

jdonszelmann force-pushed the rename-probe branch from 62c0c0e to 28b06a6 Compare April 2, 2026 09:24

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154578 - jdonszelmann:rename-probe, r=lcnr,…

cc98d0a

…boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 8 pull requests #154714

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154578 - jdonszelmann:rename-probe, r=lcnr,…

a8187da

…boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154716

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154578 - jdonszelmann:rename-probe, r=lcnr,…

ce26d07

…boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154718

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 20 pull requests #154727

Merged

rust-bors bot merged commit 1c15595 into rust-lang:main Apr 2, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Apr 2, 2026

rust-timer added a commit that referenced this pull request Apr 2, 2026

Unrolled build for #154578

45fc363

Rollup merge of #154578 - jdonszelmann:rename-probe, r=lcnr,boxyuwu Rename `probe_ty_var` to `try_resolve_ty_var` r? @lcnr

Uh oh!

Conversation

jdonszelmann commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

lcnr commented Mar 30, 2026

Uh oh!

rust-bors bot commented Mar 30, 2026

Uh oh!

BoxyUwU commented Mar 30, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Mar 30, 2026

Uh oh!

jdonszelmann commented Mar 30, 2026

Uh oh!

BoxyUwU left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Mar 30, 2026

Uh oh!

BoxyUwU commented Mar 31, 2026

Uh oh!

rustbot commented Apr 2, 2026

Uh oh!

jdonszelmann commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BoxyUwU left a comment •

edited by rustbot

Loading