Skip to content

mGCA: Lower spans for literal const args#154469

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
reddevilmidzy:mgca-lower
Apr 2, 2026
Merged

mGCA: Lower spans for literal const args#154469
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
reddevilmidzy:mgca-lower

Conversation

@reddevilmidzy
Copy link
Copy Markdown
Member

@reddevilmidzy reddevilmidzy commented Mar 27, 2026 •
edited
Loading

resolve: #152653
resolve: #154636

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2026
@reddevilmidzy reddevilmidzy reopened this Mar 27, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2026
@reddevilmidzy reddevilmidzy reopened this Mar 27, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 27, 2026
@reddevilmidzy
Copy link
Copy Markdown
Member Author

reddevilmidzy commented Mar 28, 2026

r? BoxyUwU

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 28, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@reddevilmidzy reddevilmidzy marked this pull request as ready for review March 28, 2026 01:59
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2026
@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented Apr 2, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 2, 2026

📌 Commit 7dc9a08 has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154469 - reddevilmidzy:mgca-lower, r=BoxyUwU
5fb8385 
mGCA: Lower spans for literal const args

resolve: rust-lang#152653
resolve: rust-lang#154636
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 2, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154469 - reddevilmidzy:mgca-lower, r=BoxyUwU
d1b5bcc 
mGCA: Lower spans for literal const args

resolve: rust-lang#152653
resolve: rust-lang#154636
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Apr 2, 2026
@bors
Auto merge of #154716 - JonathanBrouwer:rollup-mjhodpw, r=JonathanBro…
fc16f98 
…uwer

Rollup of 21 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153286 (various fixes for scalable vectors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #154713 (Stop compiling when we get resolving crate failure)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154469 - reddevilmidzy:mgca-lower, r=BoxyUwU
4f172b5 
mGCA: Lower spans for literal const args

resolve: rust-lang#152653
resolve: rust-lang#154636
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Apr 2, 2026
@bors
Auto merge of #154718 - JonathanBrouwer:rollup-52sF5zX, r=JonathanBro…
0e9b775 
…uwer

Rollup of 21 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153286 (various fixes for scalable vectors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #153614 (`FindParamInClause` handle edge-cases)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Apr 2, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 2, 2026
@bors
Auto merge of #154727 - JonathanBrouwer:rollup-I3Rg5V6, r=JonathanBro…
55e86c9 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #153614 (`FindParamInClause` handle edge-cases)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)
@rust-bors rust-bors bot merged commit 2eb2c90 into rust-lang:main Apr 2, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 2, 2026
rust-timer added a commit that referenced this pull request Apr 2, 2026
@rust-timer
Unrolled build for #154469
e65347f 
Rollup merge of #154469 - reddevilmidzy:mgca-lower, r=BoxyUwU

mGCA: Lower spans for literal const args

resolve: #152653
resolve: #154636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Human9000-bit Human9000-bit Human9000-bit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

[ICE]: invalid field access on immediate [ICE]: attempting to project to field at offset 0 with size 8 into immediate

5 participants

@reddevilmidzy @rust-log-analyzer @rustbot @BoxyUwU @Human9000-bit