Attributes containing rustc by jdonszelmann · Pull Request #153532 · rust-lang/rust

jdonszelmann · 2026-03-07T09:30:22Z

I noticed that attributes containing the word rustc as a segment also error with a message referring to "starting with rustc". The first commit shows this going wrong by re-exporting #[test], a built-in macro, from a module called rustc.

The 2nd commit addresses this by changing the diagnostic. However, given the wording I wonder if the real solution shouldn't be to allow attributes containing a rustc segment and only disallow them when they start. In other words, actually implement the behavior that the original diagnostic pointed out.

jdonszelmann · 2026-03-07T09:37:48Z

also discussed here: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Should.20we.20reject.20attributes.20*starting*.20or.20*containing*.20rustc/with/577898849

neo-tree filesystem [1]

jdonszelmann · 2026-03-09T09:19:43Z

Removed the test I added in commit 1, since we already test similar behavior somewhere else (see the other test I blessed). Kept it in the first commit to demonstrate old behavior.

JonathanBrouwer

Not sure if you want specifically petrochenkov to take a look, if not r=me

View changes since this review

JonathanBrouwer · 2026-03-09T20:44:17Z

compiler/rustc_resolve/src/macros.rs

@@ -618,15 +612,23 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
        }

        // Report errors for the resolved macro.
+        let mut first = true;
        for segment in &path.segments {


nit: I'd prefer doing this with enumerate rather than a variable

petrochenkov · 2026-03-10T14:13:34Z

r=me with #153532 (comment) addressed.
@rustbot author

rustbot · 2026-03-10T14:13:39Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-04-02T09:10:48Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-04-02T09:44:28Z

@bors r=petrochenkov

rust-bors · 2026-04-02T09:44:32Z

📌 Commit 3e0572e has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…-rustc, r=petrochenkov Attributes containing rustc r? @petrochenkov I noticed that attributes *containing* the word rustc as a segment also error with a message referring to "starting with rustc". The first commit shows this going wrong by re-exporting `#[test]`, a built-in macro, from a module called rustc. The 2nd commit addresses this by changing the diagnostic. However, given the wording I wonder if the real solution shouldn't be to allow attributes containing a `rustc` segment and only disallow them when they start. In other words, actually implement the behavior that the original diagnostic pointed out.

@petrochenkov

…-rustc, r=petrochenkov Attributes containing rustc r? @petrochenkov I noticed that attributes *containing* the word rustc as a segment also error with a message referring to "starting with rustc". The first commit shows this going wrong by re-exporting `#[test]`, a built-in macro, from a module called rustc. The 2nd commit addresses this by changing the diagnostic. However, given the wording I wonder if the real solution shouldn't be to allow attributes containing a `rustc` segment and only disallow them when they start. In other words, actually implement the behavior that the original diagnostic pointed out.

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #154713 (Stop compiling when we get resolving crate failure) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

@petrochenkov

…-rustc, r=petrochenkov Attributes containing rustc r? @petrochenkov I noticed that attributes *containing* the word rustc as a segment also error with a message referring to "starting with rustc". The first commit shows this going wrong by re-exporting `#[test]`, a built-in macro, from a module called rustc. The 2nd commit addresses this by changing the diagnostic. However, given the wording I wonder if the real solution shouldn't be to allow attributes containing a `rustc` segment and only disallow them when they start. In other words, actually implement the behavior that the original diagnostic pointed out.

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…uwer Rollup of 20 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

@petrochenkov

Rollup merge of #153532 - jdonszelmann:attributes-containing-rustc, r=petrochenkov Attributes containing rustc r? @petrochenkov I noticed that attributes *containing* the word rustc as a segment also error with a message referring to "starting with rustc". The first commit shows this going wrong by re-exporting `#[test]`, a built-in macro, from a module called rustc. The 2nd commit addresses this by changing the diagnostic. However, given the wording I wonder if the real solution shouldn't be to allow attributes containing a `rustc` segment and only disallow them when they start. In other words, actually implement the behavior that the original diagnostic pointed out.

rustbot assigned petrochenkov Mar 7, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 7, 2026

JonathanBrouwer reviewed Mar 7, 2026

View reviewed changes

neo-tree filesystem [1] Outdated Show resolved Hide resolved

jdonszelmann force-pushed the attributes-containing-rustc branch 2 times, most recently from 53123a4 to f6b4e4e Compare March 7, 2026 09:41

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the attributes-containing-rustc branch from f6b4e4e to 951e9d7 Compare March 9, 2026 09:19

JonathanBrouwer approved these changes Mar 9, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

jdonszelmann added 2 commits March 23, 2026 12:05

using rustc in the middle of an attrpath errors

5f2790c

improve diagnostics for attrs that *contain* the word rustc

3e0572e

jdonszelmann force-pushed the attributes-containing-rustc branch from 951e9d7 to 3e0572e Compare April 2, 2026 09:10

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2026

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 8 pull requests #154714

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154716

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154718

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 20 pull requests #154727

Merged

rust-bors bot merged commit 45cec8b into rust-lang:main Apr 2, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Attributes containing rustc#153532

Attributes containing rustc#153532
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
jdonszelmann:attributes-containing-rustc

jdonszelmann commented Mar 7, 2026

Uh oh!

jdonszelmann commented Mar 7, 2026

Uh oh!

Uh oh!

This comment has been minimized.

jdonszelmann commented Mar 9, 2026

Uh oh!

JonathanBrouwer left a comment •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer Mar 9, 2026

Uh oh!

petrochenkov commented Mar 10, 2026

Uh oh!

rustbot commented Mar 10, 2026

Uh oh!

rustbot commented Apr 2, 2026

Uh oh!

jdonszelmann commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jdonszelmann commented Mar 7, 2026

Uh oh!

jdonszelmann commented Mar 7, 2026

Uh oh!

Uh oh!

This comment has been minimized.

jdonszelmann commented Mar 9, 2026

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented Mar 10, 2026

Uh oh!

rustbot commented Mar 10, 2026

Uh oh!

rustbot commented Apr 2, 2026

Uh oh!

jdonszelmann commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JonathanBrouwer left a comment •

edited by rustbot

Loading