tidy-alphabetical: fix line number in error message by scrabsha · Pull Request #154213 · rust-lang/rust

scrabsha · 2026-03-22T12:32:13Z

the comment should explain the situation. if it does not please let me know and i'll try to make it better :3

reddevilmidzy · 2026-03-22T13:38:50Z

If you want to verify CI pass, you can open a PR as a draft without needing to add a block label. S-waiting-author label includes that meaning.

scrabsha · 2026-03-22T15:28:17Z

r? WaffleLapkin (you reworked this bit a few months ago, so i figured you'd be a good entity to ask a review from hehe)

@rustbot ready

rustbot · 2026-03-22T15:28:22Z

WaffleLapkin is currently at their maximum review capacity.
They may take a while to respond.

WaffleLapkin · 2026-04-02T06:03:55Z

src/tools/tidy/src/alphabetical/tests.rs

        // tidy-alphabetical-end
    ";
-    bad(lines, "bad:2: line not in alphabetical order (tip: use --bless to sort this list)");
+    bad(lines, "bad:3: line not in alphabetical order (tip: use --bless to sort this list)");


lines are typically 1-indexed, so shouldn't this actually point to 4?

mhm, the first line of lines is // tidy-alphabetical-start¹ and this lint points at the first line that needs changes, which is xyz, aka the third line

that's how i understand it, but maybe i'm wrong?

Footnotes

i wasn't sure so i wrote a cute lill test for it: playground ↩

M, no, you are right. For some reason I thought that in a c b the problem is in b which needs to be between a/c, but it is just as meaningful to say that the problem is c which needs to be after b.

WaffleLapkin · 2026-04-02T06:55:01Z

@bors r+ rollup

rust-bors · 2026-04-02T06:55:04Z

📌 Commit 8946711 has been approved by WaffleLapkin

It is now in the queue for this repository.

…leLapkin tidy-alphabetical: fix line number in error message

Rollup of 11 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154213 (tidy-alphabetical: fix line number in error message) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)

…leLapkin tidy-alphabetical: fix line number in error message

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #154713 (Stop compiling when we get resolving crate failure) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…leLapkin tidy-alphabetical: fix line number in error message

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…leLapkin tidy-alphabetical: fix line number in error message

…uwer Rollup of 20 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

This comment has been minimized.

Sign in to view

tidy-alphabetical: fix line number in error message

8946711

scrabsha force-pushed the push-znnnnwtwxntz branch from a23ae00 to 8946711 Compare March 22, 2026 12:53

reddevilmidzy removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 22, 2026

rustbot assigned WaffleLapkin Mar 22, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2026

scrabsha marked this pull request as ready for review March 22, 2026 15:28

WaffleLapkin reviewed Apr 2, 2026

View reviewed changes

WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2026

WaffleLapkin approved these changes Apr 2, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154213 - scrabsha:push-znnnnwtwxntz, r=Waff…

0aa7f45

…leLapkin tidy-alphabetical: fix line number in error message

jhpratt mentioned this pull request Apr 2, 2026

Rollup of 11 pull requests #154705

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154213 - scrabsha:push-znnnnwtwxntz, r=Waff…

8b1f38a

…leLapkin tidy-alphabetical: fix line number in error message

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154716

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154213 - scrabsha:push-znnnnwtwxntz, r=Waff…

7816d67

…leLapkin tidy-alphabetical: fix line number in error message

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154718

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026

Rollup merge of rust-lang#154213 - scrabsha:push-znnnnwtwxntz, r=Waff…

2454f84

…leLapkin tidy-alphabetical: fix line number in error message

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 20 pull requests #154727

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tidy-alphabetical: fix line number in error message#154213

tidy-alphabetical: fix line number in error message#154213
scrabsha wants to merge 1 commit intorust-lang:mainfrom
scrabsha:push-znnnnwtwxntz

scrabsha commented Mar 22, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

reddevilmidzy commented Mar 22, 2026

Uh oh!

scrabsha commented Mar 22, 2026

Uh oh!

rustbot commented Mar 22, 2026

Uh oh!

WaffleLapkin Apr 2, 2026

Uh oh!

scrabsha Apr 2, 2026 •

edited

Loading

Uh oh!

WaffleLapkin Apr 2, 2026

Uh oh!

WaffleLapkin commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

scrabsha commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

reddevilmidzy commented Mar 22, 2026

Uh oh!

scrabsha commented Mar 22, 2026

Uh oh!

rustbot commented Mar 22, 2026

Uh oh!

WaffleLapkin Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

scrabsha Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Footnotes

Uh oh!

WaffleLapkin Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

WaffleLapkin commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

scrabsha commented Mar 22, 2026 •

edited

Loading

scrabsha Apr 2, 2026 •

edited

Loading