Migrate transmute tests by ujjwalvishwakarma2006 · Pull Request #154425 · rust-lang/rust

ujjwalvishwakarma2006 · 2026-03-26T14:53:42Z

I have made the following changes in this PR:

tests/ui/issues/issue-23477.rs ➝ tests/ui/transmute/transmute-slice-to-dst.rs
tests/ui/issues/issue-28625.{rs,stderr} ➝ tests/ui/transmute/transmute-associated-type-to-slice.{rs,stderr}

The reason I changed the trait name from trait Bar to trait MyTrait and type Bar to type MyType is that the same name (i.e., Bar) for the trait and associated type was making it harder to follow the test. It was confusing for me, at least.

r? Kivooeo

…to-dst.rs

rustbot · 2026-03-28T12:12:29Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Teapot4195

I think it would be best naming it something like transmute-slice-to-struct instead of transmute-slice-to-dst.

Otherwise, LGTM (I only quickly skimmed the issues referenced, but where they went seems sane to me).

View changes since this review

ujjwalvishwakarma2006 · 2026-03-30T19:21:34Z

I think it would be best naming it something like transmute-slice-to-struct instead of transmute-slice-to-dst.

Otherwise, LGTM (I only quickly skimmed the issues referenced, but where they went seems sane to me).

View changes since this review

Noted!!

Kivooeo · 2026-04-02T10:26:01Z

@bors r+ rollup

rust-bors · 2026-04-02T10:26:04Z

📌 Commit a261c8c has been approved by Kivooeo

It is now in the queue for this repository.

Kivooeo · 2026-04-02T10:26:27Z

@bors r-

@bors r=Kivooeo,Teapot4195 rollup

rust-bors · 2026-04-02T10:26:33Z

📌 Commit a261c8c has been approved by Kivooeo,Teapot4195

It is now in the queue for this repository.

⚠️ The following reviewer(s) could not be found: Teapot4195

ujjwalvishwakarma2006 · 2026-04-02T11:37:46Z

Hi, I haven't squashed modification commits. Should I do it now? It's already rolled up.

Kivooeo · 2026-04-02T11:57:45Z

nah it's fine

next time you don't have to keep them separate

…smute-tests, r=Kivooeo,Teapot4195 Migrate transmute tests I have made the following changes in this PR: - `tests/ui/issues/issue-23477.rs` ➝ `tests/ui/transmute/transmute-slice-to-dst.rs` - `tests/ui/issues/issue-28625.{rs,stderr}` ➝ `tests/ui/transmute/transmute-associated-type-to-slice.{rs,stderr}` The reason I changed the trait name from `trait Bar` to `trait MyTrait` and `type Bar` to `type MyType` is that the same name (i.e., `Bar`) for the trait and associated type was making it harder to follow the test. It was confusing for me, at least. r? Kivooeo

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #154713 (Stop compiling when we get resolving crate failure) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…smute-tests, r=Kivooeo,Teapot4195 Migrate transmute tests I have made the following changes in this PR: - `tests/ui/issues/issue-23477.rs` ➝ `tests/ui/transmute/transmute-slice-to-dst.rs` - `tests/ui/issues/issue-28625.{rs,stderr}` ➝ `tests/ui/transmute/transmute-associated-type-to-slice.{rs,stderr}` The reason I changed the trait name from `trait Bar` to `trait MyTrait` and `type Bar` to `type MyType` is that the same name (i.e., `Bar`) for the trait and associated type was making it harder to follow the test. It was confusing for me, at least. r? Kivooeo

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…smute-tests, r=Kivooeo,Teapot4195 Migrate transmute tests I have made the following changes in this PR: - `tests/ui/issues/issue-23477.rs` ➝ `tests/ui/transmute/transmute-slice-to-dst.rs` - `tests/ui/issues/issue-28625.{rs,stderr}` ➝ `tests/ui/transmute/transmute-associated-type-to-slice.{rs,stderr}` The reason I changed the trait name from `trait Bar` to `trait MyTrait` and `type Bar` to `type MyType` is that the same name (i.e., `Bar`) for the trait and associated type was making it harder to follow the test. It was confusing for me, at least. r? Kivooeo

…uwer Rollup of 20 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

ujjwalvishwakarma2006 added 4 commits March 26, 2026 19:55

Move 3 files (2 .rs and 1 .stderr) from ui/issues to ui/transmute

3250d8d

Add issue link at the top in file tests/ui/transmute/transmute-slice-…

58ceac1

…to-dst.rs

Add issue link, and update trait and type names for better readability

e0f17b9

Add updated .stderr file

a261c8c

rustbot assigned Kivooeo Mar 26, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2026

ujjwalvishwakarma2006 marked this pull request as ready for review March 28, 2026 12:12

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2026

Teapot4195 reviewed Mar 30, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 2, 2026

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 8 pull requests #154714

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154716

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 21 pull requests #154718

Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026

Rollup of 20 pull requests #154727

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate transmute tests#154425

Migrate transmute tests#154425
ujjwalvishwakarma2006 wants to merge 4 commits intorust-lang:mainfrom
ujjwalvishwakarma2006:migrate-transmute-tests

ujjwalvishwakarma2006 commented Mar 26, 2026 •

edited

Loading

Uh oh!

rustbot commented Mar 28, 2026

Uh oh!

Teapot4195 left a comment •

edited

Loading

Uh oh!

ujjwalvishwakarma2006 commented Mar 30, 2026

Uh oh!

Kivooeo commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Kivooeo commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

ujjwalvishwakarma2006 commented Apr 2, 2026 •

edited

Loading

Uh oh!

Kivooeo commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ujjwalvishwakarma2006 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 28, 2026

Uh oh!

Teapot4195 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ujjwalvishwakarma2006 commented Mar 30, 2026

Uh oh!

Kivooeo commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

Kivooeo commented Apr 2, 2026

Uh oh!

rust-bors bot commented Apr 2, 2026

Uh oh!

ujjwalvishwakarma2006 commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ujjwalvishwakarma2006 commented Mar 26, 2026 •

edited

Loading

Teapot4195 left a comment •

edited

Loading

ujjwalvishwakarma2006 commented Apr 2, 2026 •

edited

Loading