Use mem::offset_of! for sockaddr_un.sun_path
#130861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
rustbot
added
O-unix
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 26, 2024
…mdev Use `mem::offset_of!` for `sockaddr_un.sun_path` We don't need manual pointer math here anymore!
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130860 (Fix directives for lint-non-snake-case-crate) - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`) - rust-lang#130865 (Use `&raw` in the standard library) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
Use `mem::offset_of!` for `sockaddr_un.sun_path` We don't need manual pointer math here anymore! try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
cuviper
force-pushed
the
sun-path-offset
branch
from
918a6e8
to
9431d1a
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
Use `mem::offset_of!` for `sockaddr_un.sun_path` We don't need manual pointer math here anymore! try-job: dist-i686-msvc
|
☀️ Try build successful - checks-actions |
|
The only change since the previous approval is adding @bors r=ibraheemdev |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 26, 2024
…mdev Use `mem::offset_of!` for `sockaddr_un.sun_path` We don't need manual pointer math here anymore! try-job: dist-i686-msvc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2024
…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#130279 (Document subtleties of `ManuallyDrop`) - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config) - rust-lang#130820 (Fix diagnostics for coroutines with () as input.) - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation) - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk) - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations) - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`) - rust-lang#130862 (rustdoc: do not animate :target when user prefers reduced motion) - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs) - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code) - rust-lang#130880 (add missing FIXME(const-hack)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
Rollup merge of rust-lang#130861 - cuviper:sun-path-offset, r=ibraheemdev Use `mem::offset_of!` for `sockaddr_un.sun_path` We don't need manual pointer math here anymore! try-job: dist-i686-msvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need manual pointer math here anymore!
try-job: dist-i686-msvc