Library: Rename "object safe" to "dyn compatible" #130827
Merged
+26
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
commented
Sep 25, 2024
library/core/src/ops/unsize.rs
Outdated
Comment on lines
116
to
117
| /// [^1]: Formerly known as *object safety*. | ||
| /// [^2]: Formerly known as *object safe*. |
There was a problem hiding this comment.
awkward duplication, thoughts?
There was a problem hiding this comment.
It seems reasonable to remove second footnote given that dyn-incompatiblity was previously defined.
fmease
added
S-waiting-on-fcp
16 tasks
fmease
removed
the
S-waiting-on-fcp
fmease
changed the title
|
r? libs (or libs-api?) |
fmease
force-pushed
the
library-mv-obj-save-dyn-compat
branch
from
77be431
to
c13d353
Compare
fmease
force-pushed
the
library-mv-obj-save-dyn-compat
branch
from
c13d353
to
e08dc04
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123951 (Reserve guarded string literals (RFC 3593)) - rust-lang#130827 (Library: Rename "object safe" to "dyn compatible") - rust-lang#131383 (Add docs about slicing slices at the ends) - rust-lang#131403 (Fix needless_lifetimes in rustc_serialize) - rust-lang#131417 (Fix methods alignment on mobile) - rust-lang#131449 (Decouple WASIp2 sockets from WasiFd) - rust-lang#131462 (Mention allocation errors for `open_buffered`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 10, 2024
Rollup merge of rust-lang#130827 - fmease:library-mv-obj-save-dyn-compat, r=ibraheemdev Library: Rename "object safe" to "dyn compatible" Completed T-lang FCP: rust-lang/lang-team#286 (comment). Tracking issue: rust-lang#130852 Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language). r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: #130852
Regarding relnotesMarks issues that should be documented in the release notes of the next release.
, I guess I will manually open a
relnotes-tracking-issue
Marks issues tracking what text to put in release notes.
since this change affects everything (compiler, library, tools, docs, books, everyday language).
r? ghost