Skip to content

Add Vec::as_non_null #130624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add Vec::as_non_null #130624

merged 1 commit into from
Sep 20, 2024

Conversation

@theemathas
Copy link
Contributor

@theemathas theemathas commented Sep 20, 2024

Implements the ACP: rust-lang/libs-team#440

The documentation is mostly copied from the existing Vec::as_mut_ptr method.

I am adding this method to the already-existing box_vec_non_null feature tracked at #130364.

@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 20, 2024
@theemathas theemathas mentioned this pull request Sep 20, 2024
Open
3 tasks
@jieyouxu jieyouxu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 20, 2024
@Noratrieb
Copy link
Member

Noratrieb commented Sep 20, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 20, 2024

📌 Commit ff86269 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 20, 2024
Merged
@bors bors merged commit 81b818e into rust-lang:master Sep 20, 2024
@rustbot rustbot added this to the 1.83.0 milestone Sep 20, 2024
@theemathas theemathas deleted the vec_as_non_null branch September 21, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

6 participants

@theemathas @rustbot @Noratrieb @bors @cuviper @jieyouxu