add InProgress ErrorKind gated behind io_error_inprogress feature #130789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Noratrieb (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
O-unix
This comment has been minimized.
This comment has been minimized.
Noratrieb
reviewed
Sep 24, 2024
|
nice, could you squash the commits together? you've got my approval afterwards 🐱 |
aviramha
force-pushed
the
add_inprogress
branch
from
f58f984
to
8450fcc
Compare
Done :) |
dtolnay
requested changes
Sep 24, 2024
aviramha
force-pushed
the
add_inprogress
branch
from
3ce7afa
to
60eddc6
Compare
Noratrieb
reviewed
Sep 24, 2024
Co-authored-by: David Tolnay <[email protected]> Co-authored-by: nora <[email protected]>
aviramha
force-pushed
the
add_inprogress
branch
from
9997343
to
46fd76e
Compare
|
thanks! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#130234 (improve compile errors for invalid ptr-to-ptr casts with trait objects) - rust-lang#130752 (Improve assembly test for CMSE ABIs) - rust-lang#130764 (Separate collection of crate-local inherent impls from error tracking) - rust-lang#130788 (Pin memchr to 2.5.0 in the library rather than rustc_ast) - rust-lang#130789 (add InProgress ErrorKind gated behind io_error_inprogress feature) - rust-lang#130793 (Mention `COMPILETEST_VERBOSE_CRASHES` on crash test failure) - rust-lang#130798 (rustdoc: inherit parent's stability where applicable) Failed merges: - rust-lang#130735 (Simple validation for unsize coercion in MIR validation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2024
Rollup merge of rust-lang#130789 - aviramha:add_inprogress, r=Noratrieb add InProgress ErrorKind gated behind io_error_inprogress feature Follow up on rust-lang/libs-team#92 (comment)
|
Should a tracking issue be created? |
|
you are absolutely correct, I noticed that during review and then forgot to comment about it, thanks. |
|
no, let me do that for you |
4 tasks
|
I put up #130842 |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 25, 2024
…s, r=jieyouxu Add tracking issue for io_error_inprogress I forgot to mention this in rust-lang#130789
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2024
Rollup merge of rust-lang#130842 - Noratrieb:tracking-issue-inprogress, r=jieyouxu Add tracking issue for io_error_inprogress I forgot to mention this in rust-lang#130789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on rust-lang/libs-team#92 (comment)